Re: [Mesa-dev] [PATCH 8/8] panfrost: Add backend targeting the DRM driver

2019-03-05 Thread Eric Anholt
Alyssa Rosenzweig writes: >> Alyssa: do you see any problem if we change to submit only one atom per >> ioctl? > > I don't think so; aesthetically I don't like the extra kernel traffic, > but that's not a real concern, and it sounds like that's the correct > approach anyway. > > A big reason we

Re: [Mesa-dev] [PATCH 8/8] panfrost: Add backend targeting the DRM driver

2019-03-05 Thread Eric Anholt
Kristian Høgsberg writes: > On Mon, Mar 4, 2019 at 6:29 PM Dave Airlie wrote: >> >> On Tue, 5 Mar 2019 at 12:20, Kristian Høgsberg wrote: >> > >> > On Mon, Mar 4, 2019 at 6:11 PM Alyssa Rosenzweig >> > wrote: >> > > >> > > > Why aren't we using regular dma-buf fences here? The submit ioctl

Re: [Mesa-dev] [PATCH 8/8] panfrost: Add backend targeting the DRM driver

2019-03-05 Thread Alyssa Rosenzweig
> Alyssa: do you see any problem if we change to submit only one atom per > ioctl? I don't think so; aesthetically I don't like the extra kernel traffic, but that's not a real concern, and it sounds like that's the correct approach anyway. A big reason we submit together on non-DRM is so we can

Re: [Mesa-dev] [PATCH 8/8] panfrost: Add backend targeting the DRM driver

2019-03-05 Thread Rob Herring
On Mon, Mar 4, 2019 at 6:43 PM Alyssa Rosenzweig wrote: > > Wooo!!! > > Seeing this patch in my inbox has been some of the best news all day! > > Without further ado, my (solicited?) comments: > > > +/* Copyright 2018, Linaro, Ltd., Rob Herring */ > > Please triple check upstream that this

Re: [Mesa-dev] [PATCH 8/8] panfrost: Add backend targeting the DRM driver

2019-03-04 Thread Tomeu Vizoso
On 3/5/19 3:29 AM, Dave Airlie wrote: On Tue, 5 Mar 2019 at 12:20, Kristian Høgsberg wrote: On Mon, Mar 4, 2019 at 6:11 PM Alyssa Rosenzweig wrote: Why aren't we using regular dma-buf fences here? The submit ioctl should be able to take a number of in fences to wait on and return an out

Re: [Mesa-dev] [PATCH 8/8] panfrost: Add backend targeting the DRM driver

2019-03-04 Thread Alyssa Rosenzweig
> You should more likely be using syncobjects, not fences. ...I still don't know what either of them actually are...? ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 8/8] panfrost: Add backend targeting the DRM driver

2019-03-04 Thread Kristian Høgsberg
On Mon, Mar 4, 2019 at 6:29 PM Dave Airlie wrote: > > On Tue, 5 Mar 2019 at 12:20, Kristian Høgsberg wrote: > > > > On Mon, Mar 4, 2019 at 6:11 PM Alyssa Rosenzweig > > wrote: > > > > > > > Why aren't we using regular dma-buf fences here? The submit ioctl > > > > should be able to take a

Re: [Mesa-dev] [PATCH 8/8] panfrost: Add backend targeting the DRM driver

2019-03-04 Thread Dave Airlie
On Tue, 5 Mar 2019 at 12:20, Kristian Høgsberg wrote: > > On Mon, Mar 4, 2019 at 6:11 PM Alyssa Rosenzweig wrote: > > > > > Why aren't we using regular dma-buf fences here? The submit ioctl > > > should be able to take a number of in fences to wait on and return an > > > out fence if requested.

Re: [Mesa-dev] [PATCH 8/8] panfrost: Add backend targeting the DRM driver

2019-03-04 Thread Kristian Høgsberg
On Mon, Mar 4, 2019 at 6:11 PM Alyssa Rosenzweig wrote: > > > Why aren't we using regular dma-buf fences here? The submit ioctl > > should be able to take a number of in fences to wait on and return an > > out fence if requested. > > Ah-ha, that sounds like the "proper" approach for mainline.

Re: [Mesa-dev] [PATCH 8/8] panfrost: Add backend targeting the DRM driver

2019-03-04 Thread Alyssa Rosenzweig
> Why aren't we using regular dma-buf fences here? The submit ioctl > should be able to take a number of in fences to wait on and return an > out fence if requested. Ah-ha, that sounds like the "proper" approach for mainline. Much of this was (incorrectly) inherited from the Arm driver. Thank

Re: [Mesa-dev] [PATCH 8/8] panfrost: Add backend targeting the DRM driver

2019-03-04 Thread Kristian Høgsberg
On Mon, Mar 4, 2019 at 4:43 PM Alyssa Rosenzweig wrote: > > Wooo!!! > > Seeing this patch in my inbox has been some of the best news all day! > > Without further ado, my (solicited?) comments: > > > +/* Copyright 2018, Linaro, Ltd., Rob Herring */ > > Please triple check upstream that this

Re: [Mesa-dev] [PATCH 8/8] panfrost: Add backend targeting the DRM driver

2019-03-04 Thread Alyssa Rosenzweig
Wooo!!! Seeing this patch in my inbox has been some of the best news all day! Without further ado, my (solicited?) comments: > +/* Copyright 2018, Linaro, Ltd., Rob Herring */ Please triple check upstream that this license is okay; the other files in include/drm-uapi are BSDish. > +/*

Re: [Mesa-dev] [PATCH 8/8] panfrost: Add backend targeting the DRM driver

2019-03-04 Thread Rob Herring
On Mon, Mar 4, 2019 at 10:12 AM Tomeu Vizoso wrote: > > This backend interacts with the new DRM driver for Midgard GPUs which is > currently in development. > > When using this backend, Panfrost has roughly on-par functionality as > when using the non-DRM driver from Arm. > > Signed-off-by: Tomeu

[Mesa-dev] [PATCH 8/8] panfrost: Add backend targeting the DRM driver

2019-03-04 Thread Tomeu Vizoso
This backend interacts with the new DRM driver for Midgard GPUs which is currently in development. When using this backend, Panfrost has roughly on-par functionality as when using the non-DRM driver from Arm. Signed-off-by: Tomeu Vizoso --- include/drm-uapi/panfrost_drm.h| 128