Re: [Mesa-dev] [PATCH 8/8] radv: enable VK_EXT_sample_locations

2019-06-04 Thread Bas Nieuwenhuizen
Most of the series looks reasonable to me besides the few comments added. That said looking back at the patch you committed I don't think we revert to the default locations the right way. We return early from radv_update_multisample_state if the old pipeline has the same number of samples, which

[Mesa-dev] [PATCH 8/8] radv: enable VK_EXT_sample_locations

2019-05-30 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_device.c | 8 src/amd/vulkan/radv_extensions.py | 2 +- 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 3cf050ed220..16efc6134f1 100644 ---