Re: [Mesa-dev] [PATCH RFC] egl/dri2: Add dri3 support to x11 platform

2015-07-06 Thread Emil Velikov
On 4 July 2015 at 04:18, Boyan Ding wrote: > Hi Emil, > > > On 07/03/2015 10:36 PM, Emil Velikov wrote: >> Hi Boyan, >> >> Thank you for doing this ! A few suggestions which you might be interesting: >> >> Considering that the backend has handled more than dri2 perhaps we can >> do a s/dri2/dri/ :

Re: [Mesa-dev] [PATCH RFC] egl/dri2: Add dri3 support to x11 platform

2015-07-06 Thread Pekka Paalanen
On Sat, 4 Jul 2015 11:18:18 +0800 Boyan Ding wrote: > >> [snip] > >> > >> +/* FIXME: Is this right? Seems problematic for WL_bind_wayland_display */ > > What seems to be the problem ? > > > > Afaik xcb_dri3_open_reply_fds should return an FD which is ok (be that a > > render_node device, or a mas

Re: [Mesa-dev] [PATCH RFC] egl/dri2: Add dri3 support to x11 platform

2015-07-04 Thread Boyan Ding
On 07/04/2015 04:17 PM, Axel Davy wrote: > On 04/07/2015 05:18, Boyan Ding wrote : >> Hi Emil, >> >> >> On 07/03/2015 10:36 PM, Emil Velikov wrote: >> [snip] +/* FIXME: Is this right? Seems problematic for WL_bind_wayland_display */ >>> What seems to be the problem ? >>> >>> Afaik

Re: [Mesa-dev] [PATCH RFC] egl/dri2: Add dri3 support to x11 platform

2015-07-04 Thread Axel Davy
On 04/07/2015 05:18, Boyan Ding wrote : Hi Emil, On 07/03/2015 10:36 PM, Emil Velikov wrote: [snip] +/* FIXME: Is this right? Seems problematic for WL_bind_wayland_display */ What seems to be the problem ? Afaik xcb_dri3_open_reply_fds should return an FD which is ok (be that a render_node

Re: [Mesa-dev] [PATCH RFC] egl/dri2: Add dri3 support to x11 platform

2015-07-03 Thread Boyan Ding
Hi Emil, On 07/03/2015 10:36 PM, Emil Velikov wrote: > Hi Boyan, > > Thank you for doing this ! A few suggestions which you might be interesting: > > Considering that the backend has handled more than dri2 perhaps we can > do a s/dri2/dri/ :-) That obviously is independent of your work. > > On 01

Re: [Mesa-dev] [PATCH RFC] egl/dri2: Add dri3 support to x11 platform

2015-07-03 Thread Emil Velikov
Hi Boyan, Thank you for doing this ! A few suggestions which you might be interesting: Considering that the backend has handled more than dri2 perhaps we can do a s/dri2/dri/ :-) That obviously is independent of your work. On 01/07/15 16:31, Boyan Ding wrote: > Signed-off-by: Boyan Ding > --- >

[Mesa-dev] [PATCH RFC] egl/dri2: Add dri3 support to x11 platform

2015-07-01 Thread Boyan Ding
Signed-off-by: Boyan Ding --- configure.ac |3 + src/egl/drivers/dri2/Makefile.am |5 + src/egl/drivers/dri2/egl_dri2.c | 65 +- src/egl/drivers/dri2/egl_dri2.h | 12 +- src/egl/drivers/dri2/platform_x11.c | 127 ++- src/egl/