Re: [Mesa-dev] [PATCH V2] radeonsi/uvd: fix planar formats broken since f70f6baaa3bb0f8b280ac2eaea69bb

2017-09-30 Thread Christian König
Am 30.09.2017 um 12:57 schrieb Benedikt Schemmer: It should be handled as an error if resource_formats[0] is PIPE_FORMAT_NONE. Better write this as: if (resource_formats[i] == PIPE_FORMAT_NONE) { if (i == 0) gotot error; continue; } ... I dont think it can be zero. In the

Re: [Mesa-dev] [PATCH V2] radeonsi/uvd: fix planar formats broken since f70f6baaa3bb0f8b280ac2eaea69bb

2017-09-30 Thread Benedikt Schemmer
yes Am 30.09.2017 um 17:53 schrieb Marek Olšák: > On Sat, Sep 30, 2017 at 5:47 PM, Christian König > wrote: >> Am 30.09.2017 um 12:57 schrieb Benedikt Schemmer: It should be handled as an error if resource_formats[0] is PIPE_FORMAT_NONE. Better

Re: [Mesa-dev] [PATCH V2] radeonsi/uvd: fix planar formats broken since f70f6baaa3bb0f8b280ac2eaea69bb

2017-09-30 Thread Marek Olšák
On Sat, Sep 30, 2017 at 5:47 PM, Christian König wrote: > Am 30.09.2017 um 12:57 schrieb Benedikt Schemmer: >>> >>> It should be handled as an error if resource_formats[0] is >>> PIPE_FORMAT_NONE. >>> >>> Better write this as: >>> >>> if (resource_formats[i] ==

Re: [Mesa-dev] [PATCH V2] radeonsi/uvd: fix planar formats broken since f70f6baaa3bb0f8b280ac2eaea69bb

2017-09-30 Thread Benedikt Schemmer
> > It should be handled as an error if resource_formats[0] is PIPE_FORMAT_NONE. > > Better write this as: > > if (resource_formats[i] == PIPE_FORMAT_NONE) { > if (i == 0) > gotot error; > continue; > } > ... > I dont think it can be zero. In the beginning of vl_video_buffer.c

Re: [Mesa-dev] [PATCH V2] radeonsi/uvd: fix planar formats broken since f70f6baaa3bb0f8b280ac2eaea69bb

2017-09-30 Thread Christian König
Am 29.09.2017 um 21:09 schrieb Benedikt Schemmer: From: Benedikt Schemmer Date: Fri, 29 Sep 2017 21:02:13 +0200 Subject: [PATCH V2] radeonsi/uvd: fix planar formats broken since f70f6baaa3bb0f8b280ac2eaea69bb V2: remove code duplication and one unnessecary variable, minor

Re: [Mesa-dev] [PATCH V2] radeonsi/uvd: fix planar formats broken since f70f6baaa3bb0f8b280ac2eaea69bb

2017-09-29 Thread Marek Olšák
Thanks. I'm keeping my patch and adding yours on top as a separate cleanup commit. I will push this after I get Rb tags for my patch from other guys. Marek On Fri, Sep 29, 2017 at 9:09 PM, Benedikt Schemmer wrote: > From: Benedikt Schemmer > Date: Fri, 29 Sep 2017

[Mesa-dev] [PATCH V2] radeonsi/uvd: fix planar formats broken since f70f6baaa3bb0f8b280ac2eaea69bb

2017-09-29 Thread Benedikt Schemmer
From: Benedikt Schemmer Date: Fri, 29 Sep 2017 21:02:13 +0200 Subject: [PATCH V2] radeonsi/uvd: fix planar formats broken since f70f6baaa3bb0f8b280ac2eaea69bb V2: remove code duplication and one unnessecary variable, minor whitespace fix --- src/gallium/drivers/radeonsi/si_uvd.c