Re: [Mesa-dev] [PATCH V3 04/19] glsl: add support for ARB_texture_multisample

2013-02-13 Thread Chris Forbes
Ouch. Thanks for catching that -- are there any other similar things I need to be aware of? On Wed, Feb 13, 2013 at 8:19 PM, Kenneth Graunke kenn...@whitecape.org wrote: On 02/08/2013 01:19 AM, Chris Forbes wrote: V2: - emit `sample` parameter properly for multisample texelFetch() - fix

Re: [Mesa-dev] [PATCH V3 04/19] glsl: add support for ARB_texture_multisample

2013-02-13 Thread Kenneth Graunke
On 02/13/2013 01:39 AM, Chris Forbes wrote: Ouch. Thanks for catching that -- are there any other similar things I need to be aware of? Not that I can think of, no. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH V3 04/19] glsl: add support for ARB_texture_multisample

2013-02-12 Thread Kenneth Graunke
On 02/08/2013 01:19 AM, Chris Forbes wrote: V2: - emit `sample` parameter properly for multisample texelFetch() - fix spurious whitespace change - introduce a new opcode ir_txf_ms rather than overloading the existing ir_txf further. This makes doing the right thing in the

[Mesa-dev] [PATCH V3 04/19] glsl: add support for ARB_texture_multisample

2013-02-08 Thread Chris Forbes
V2: - emit `sample` parameter properly for multisample texelFetch() - fix spurious whitespace change - introduce a new opcode ir_txf_ms rather than overloading the existing ir_txf further. This makes doing the right thing in the driver somewhat simpler. V3: - fix weird