Re: [Mesa-dev] [PATCH mesa] build: make passing an incorrect pointer type a hard error

2018-11-28 Thread Emil Velikov
On 2018/11/23, Eric Engestrom wrote: > On Thursday, 2018-11-22 15:04:54 +, Emil Velikov wrote: > > Please add the hunk back? > > Right, I thought the -Wno-error after the -Werror=foo would disable all > -Werror=*, but after testing it, you're right, I had misunderstood. > Adding the android h

Re: [Mesa-dev] [PATCH mesa] build: make passing an incorrect pointer type a hard error

2018-11-23 Thread Eric Engestrom
On Thursday, 2018-11-22 15:04:54 +, Emil Velikov wrote: > On 2018/11/22, Eric Engestrom wrote: > > On Thursday, 2018-11-22 13:15:05 +, Eric Engestrom wrote: > > > More or less any of this issue pointed out by the compiler is > > > a coding error. Make sure we flag it and bail loudly. > > >

Re: [Mesa-dev] [PATCH mesa] build: make passing an incorrect pointer type a hard error

2018-11-22 Thread Emil Velikov
On 2018/11/22, Eric Engestrom wrote: > On Thursday, 2018-11-22 13:15:05 +, Eric Engestrom wrote: > > More or less any of this issue pointed out by the compiler is > > a coding error. Make sure we flag it and bail loudly. > > > > v2: - apply the change to autotools and scons as well (Emil) > >

Re: [Mesa-dev] [PATCH mesa] build: make passing an incorrect pointer type a hard error

2018-11-22 Thread Eric Engestrom
On Thursday, 2018-11-22 13:15:05 +, Eric Engestrom wrote: > More or less any of this issue pointed out by the compiler is > a coding error. Make sure we flag it and bail loudly. > > v2: - apply the change to autotools and scons as well (Emil) > - C++ doesn't need this, it's already an erro

[Mesa-dev] [PATCH mesa] build: make passing an incorrect pointer type a hard error

2018-11-22 Thread Eric Engestrom
More or less any of this issue pointed out by the compiler is a coding error. Make sure we flag it and bail loudly. v2: - apply the change to autotools and scons as well (Emil) - C++ doesn't need this, it's already an error and the flag doesn't exist (Gert) Signed-off-by: Eric Engestrom