Re: [Mesa-dev] [PATCH mesa] omx: always define ENABLE_ST_OMX_{BELLAGIO, TIZONIA}

2018-03-12 Thread Dylan Baker
Quoting Eric Engestrom (2018-03-12 11:05:51) > On Monday, 2018-03-12 10:19:49 -0700, Dylan Baker wrote: > > Quoting Eric Engestrom (2018-03-12 07:33:27) > > > We're trying to be -Wundef clean so that we can turn it on (and > > > eventually make it an error). > > > > > > Note that the OMX code

Re: [Mesa-dev] [PATCH mesa] omx: always define ENABLE_ST_OMX_{BELLAGIO, TIZONIA}

2018-03-12 Thread Eric Engestrom
On Monday, 2018-03-12 10:19:49 -0700, Dylan Baker wrote: > Quoting Eric Engestrom (2018-03-12 07:33:27) > > We're trying to be -Wundef clean so that we can turn it on (and > > eventually make it an error). > > > > Note that the OMX code already used `#if ENABLE_ST_OMX_BELLAGIO` instead > > of

Re: [Mesa-dev] [PATCH mesa] omx: always define ENABLE_ST_OMX_{BELLAGIO, TIZONIA}

2018-03-12 Thread Dylan Baker
Quoting Eric Engestrom (2018-03-12 07:33:27) > We're trying to be -Wundef clean so that we can turn it on (and > eventually make it an error). > > Note that the OMX code already used `#if ENABLE_ST_OMX_BELLAGIO` instead > of #ifdef; I could've changed these, but the point of -Wundef is to > catch

Re: [Mesa-dev] [PATCH mesa] omx: always define ENABLE_ST_OMX_{BELLAGIO, TIZONIA}

2018-03-12 Thread Emil Velikov
On 12 March 2018 at 14:33, Eric Engestrom wrote: > We're trying to be -Wundef clean so that we can turn it on (and > eventually make it an error). > > Note that the OMX code already used `#if ENABLE_ST_OMX_BELLAGIO` instead > of #ifdef; I could've changed these, but the

[Mesa-dev] [PATCH mesa] omx: always define ENABLE_ST_OMX_{BELLAGIO, TIZONIA}

2018-03-12 Thread Eric Engestrom
We're trying to be -Wundef clean so that we can turn it on (and eventually make it an error). Note that the OMX code already used `#if ENABLE_ST_OMX_BELLAGIO` instead of #ifdef; I could've changed these, but the point of -Wundef is to catch typos, so we might as well make the change the right