Re: [Mesa-dev] [PATCH mesa] vma/tests: cast away implementation detail of using strtoul()

2018-06-06 Thread Dylan Baker
Yeah, Scott and I thought that went to the list before I did an offer the shoulder review, then realized it didn't after pushing. On June 6, 2018 10:31:38 AM PDT, Eric Anholt wrote: >Eric Engestrom writes: > >> On MacOS, the build fails because of a compiler complaint about >> a downcast: >>

Re: [Mesa-dev] [PATCH mesa] vma/tests: cast away implementation detail of using strtoul()

2018-06-06 Thread Eric Anholt
Eric Engestrom writes: > On MacOS, the build fails because of a compiler complaint about > a downcast: > > vma_random_test.cpp:239:18: error: non-constant-expression cannot be > narrowed from type 'unsigned long' to 'uint_fast32_t' (aka 'unsigned int') in > initializer list

[Mesa-dev] [PATCH mesa] vma/tests: cast away implementation detail of using strtoul()

2018-06-05 Thread Eric Engestrom
On MacOS, the build fails because of a compiler complaint about a downcast: vma_random_test.cpp:239:18: error: non-constant-expression cannot be narrowed from type 'unsigned long' to 'uint_fast32_t' (aka 'unsigned int') in initializer list [-Wc++11-narrowing] random_test r{seed};