Re: [Mesa-dev] [PATCH mesa 1/2] Add processor topology calculation implementation for Darwin/OSX targets.

Code looks good. I'm not able to test it, but it's isolated within #defined( __APPLE__). Thanks for the contribution. Reviewed-by: Bruce Cherniak > On Mar 14, 2018, at 6:19 PM, Jeremy Huddleston Sequoia > wrote: > > From: Apple SWE

Re: [Mesa-dev] [PATCH mesa 1/2] Add processor topology calculation implementation for Darwin/OSX targets.

Sent from my iPhone... > On Mar 14, 2018, at 16:41, Matt Turner wrote: > > Subject should have a swr prefix or similar. > > On Wed, Mar 14, 2018 at 4:19 PM, Jeremy Huddleston Sequoia > wrote: >> From: Apple SWE > > Explain? I

Re: [Mesa-dev] [PATCH mesa 1/2] Add processor topology calculation implementation for Darwin/OSX targets.

On Wed, Mar 14, 2018 at 5:07 PM, Jeremy Sequoia wrote: >> Please don't push code to maintained drivers without going through the >> mailing list. I feel like I shouldn't have to say that. > > In the past there hasn’t been much care about code in __APPLE__, so I figured > it

Re: [Mesa-dev] [PATCH mesa 1/2] Add processor topology calculation implementation for Darwin/OSX targets.

Subject should have a swr prefix or similar. On Wed, Mar 14, 2018 at 4:19 PM, Jeremy Huddleston Sequoia wrote: > From: Apple SWE Explain? > > The implementation for bootstrapping SWR on Darwin targets is based on the > Linux version. > Instead of

[Mesa-dev] [PATCH mesa 1/2] Add processor topology calculation implementation for Darwin/OSX targets.

From: Apple SWE The implementation for bootstrapping SWR on Darwin targets is based on the Linux version. Instead of reading the output of /proc/cpuinfo, sysctlbyname is used to determine the physical identifiers, processor identifiers, core counts and thread-processor