Re: [Mesa-dev] [PATCH mesa 1/2] buildsys: move file regeneration logic to the script itself

2017-10-27 Thread Eric Engestrom
On Thursday, 2017-10-26 10:10:19 -0700, Dylan Baker wrote: > I have a few tiny nits, but otherwise this seems fine: > Reviewed-by: Dylan Baker > > Quoting Eric Engestrom (2017-10-26 08:40:56) > > Suggested-by: Jordan Justen > > Signed-off-by: Eric

Re: [Mesa-dev] [PATCH mesa 1/2] buildsys: move file regeneration logic to the script itself

2017-10-26 Thread Jordan Justen
Both Reviewed-by: Jordan Justen Cc: Dylan On 2017-10-26 08:40:56, Eric Engestrom wrote: > Suggested-by: Jordan Justen > Signed-off-by: Eric Engestrom > --- > bin/git_sha1_gen.py | 13

Re: [Mesa-dev] [PATCH mesa 1/2] buildsys: move file regeneration logic to the script itself

2017-10-26 Thread Dylan Baker
I have a few tiny nits, but otherwise this seems fine: Reviewed-by: Dylan Baker Quoting Eric Engestrom (2017-10-26 08:40:56) > Suggested-by: Jordan Justen > Signed-off-by: Eric Engestrom > --- > bin/git_sha1_gen.py

[Mesa-dev] [PATCH mesa 1/2] buildsys: move file regeneration logic to the script itself

2017-10-26 Thread Eric Engestrom
Suggested-by: Jordan Justen Signed-off-by: Eric Engestrom --- bin/git_sha1_gen.py | 13 - src/Makefile.am | 15 --- src/SConscript | 22