Re: [Mesa-dev] [PATCH mesa 16/16] util: use NDEBUG to guard asserts

2017-11-30 Thread Eric Engestrom
On Tuesday, 2017-11-28 20:19:46 +0100, Gert Wollny wrote: > Am Dienstag, den 28.11.2017, 10:53 + schrieb Eric Engestrom: > > > > > The parameters to a preprocessor macro are (basically) just > > > text.  They are not evaluated until after the macro is > > > expanded.  I'm 93.2% sure removing

Re: [Mesa-dev] [PATCH mesa 16/16] util: use NDEBUG to guard asserts

2017-11-28 Thread Gert Wollny
Am Dienstag, den 28.11.2017, 10:53 + schrieb Eric Engestrom: > > > The parameters to a preprocessor macro are (basically) just > > text.  They are not evaluated until after the macro is > > expanded.  I'm 93.2% sure removing the guards around the assert() > > should be fine in this case. > >

Re: [Mesa-dev] [PATCH mesa 16/16] util: use NDEBUG to guard asserts

2017-11-28 Thread Eric Engestrom
On Monday, 2017-11-27 12:53:39 -0800, Ian Romanick wrote: > On 11/27/2017 10:46 AM, Dylan Baker wrote: > > Quoting Eric Engestrom (2017-11-27 09:46:57) > >> On Saturday, 2017-11-25 18:45:14 +0100, Gert Wollny wrote: > >>> Am Freitag, den 24.11.2017, 18:07 + schrieb Eric Engestrom: >

Re: [Mesa-dev] [PATCH mesa 16/16] util: use NDEBUG to guard asserts

2017-11-27 Thread Ian Romanick
On 11/27/2017 10:46 AM, Dylan Baker wrote: > Quoting Eric Engestrom (2017-11-27 09:46:57) >> On Saturday, 2017-11-25 18:45:14 +0100, Gert Wollny wrote: >>> Am Freitag, den 24.11.2017, 18:07 + schrieb Eric Engestrom: Signed-off-by: Eric Engestrom ---  

Re: [Mesa-dev] [PATCH mesa 16/16] util: use NDEBUG to guard asserts

2017-11-27 Thread Dylan Baker
Quoting Eric Engestrom (2017-11-27 09:46:57) > On Saturday, 2017-11-25 18:45:14 +0100, Gert Wollny wrote: > > Am Freitag, den 24.11.2017, 18:07 + schrieb Eric Engestrom: > > > Signed-off-by: Eric Engestrom > > > --- > > >  src/util/ralloc.c | 18 +- >

Re: [Mesa-dev] [PATCH mesa 16/16] util: use NDEBUG to guard asserts

2017-11-27 Thread Eric Engestrom
On Saturday, 2017-11-25 18:45:14 +0100, Gert Wollny wrote: > Am Freitag, den 24.11.2017, 18:07 + schrieb Eric Engestrom: > > Signed-off-by: Eric Engestrom > > --- > >  src/util/ralloc.c | 18 +- > >  src/util/slab.c   |  4 ++-- > >  2 files changed,

Re: [Mesa-dev] [PATCH mesa 16/16] util: use NDEBUG to guard asserts

2017-11-25 Thread Gert Wollny
Am Freitag, den 24.11.2017, 18:07 + schrieb Eric Engestrom: > Signed-off-by: Eric Engestrom > --- >  src/util/ralloc.c | 18 +- >  src/util/slab.c   |  4 ++-- >  2 files changed, 11 insertions(+), 11 deletions(-) > > diff --git a/src/util/ralloc.c

[Mesa-dev] [PATCH mesa 16/16] util: use NDEBUG to guard asserts

2017-11-24 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/util/ralloc.c | 18 +- src/util/slab.c | 4 ++-- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/util/ralloc.c b/src/util/ralloc.c index 42cfa2e391d52df68db2..b52079ac075a0fe11944 100644 ---