Re: [Mesa-dev] [PATCH mesa 3/6] vulkan/wsi/display: pass the plane's modifiers to the image

2018-10-03 Thread Daniel Stone
On Thu, 27 Sep 2018 at 00:33, Keith Packard wrote: > Eric Engestrom writes: > > Signed-off-by: Eric Engestrom > > (I'll have to let someone familiar with the formats and modifiers stuff > review this one; I'm not comfortable with that at all). For my sins, I am, and this patch is: Reviewed-by:

Re: [Mesa-dev] [PATCH mesa 3/6] vulkan/wsi/display: pass the plane's modifiers to the image

2018-09-27 Thread andrey simiklit
Hi, Please find my comment below: Regards, Andrii. On Wed, Sep 26, 2018 at 6:39 PM Eric Engestrom wrote: > Signed-off-by: Eric Engestrom > --- > src/vulkan/wsi/wsi_common_display.c | 95 - > 1 file changed, 94 insertions(+), 1 deletion(-) > > diff --git a/src/vulk

Re: [Mesa-dev] [PATCH mesa 3/6] vulkan/wsi/display: pass the plane's modifiers to the image

2018-09-26 Thread Keith Packard
Eric Engestrom writes: > Signed-off-by: Eric Engestrom (I'll have to let someone familiar with the formats and modifiers stuff review this one; I'm not comfortable with that at all). -- -keith signature.asc Description: PGP signature ___ mesa-dev

[Mesa-dev] [PATCH mesa 3/6] vulkan/wsi/display: pass the plane's modifiers to the image

2018-09-26 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/vulkan/wsi/wsi_common_display.c | 95 - 1 file changed, 94 insertions(+), 1 deletion(-) diff --git a/src/vulkan/wsi/wsi_common_display.c b/src/vulkan/wsi/wsi_common_display.c index 6c9160a445c8f25a8ad5..2a30b1139f06cbb56769 10064