Re: [Mesa-dev] [PATCH shader-db] run: don't use alloca to avoid random crashes in the GLSL compiler

2016-12-12 Thread Eero Tamminen
Hi, On 07.12.2016 20:03, Ian Romanick wrote: On 12/07/2016 09:44 AM, Marek Olšák wrote: On Wed, Dec 7, 2016 at 6:42 PM, Ilia Mirkin wrote: What's wrong with feeding it stack memory? I don't really have an answer to that. > Does valgrind provide any clues? Valgrind isn't so good at debug

Re: [Mesa-dev] [PATCH shader-db] run: don't use alloca to avoid random crashes in the GLSL compiler

2016-12-09 Thread Marek Olšák
On Sat, Dec 10, 2016 at 2:07 AM, Timothy Arceri wrote: > On Wed, 2016-12-07 at 18:33 +0100, Marek Olšák wrote: >> From: Marek Olšák >> >> --- >> run.c | 6 +- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/run.c b/run.c >> index 08fd543..ded224a 100644 >> --- a/run.c >>

Re: [Mesa-dev] [PATCH shader-db] run: don't use alloca to avoid random crashes in the GLSL compiler

2016-12-09 Thread Timothy Arceri
On Wed, 2016-12-07 at 18:33 +0100, Marek Olšák wrote: > From: Marek Olšák > > --- >  run.c | 6 +- >  1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/run.c b/run.c > index 08fd543..ded224a 100644 > --- a/run.c > +++ b/run.c > @@ -656,28 +656,32 @@ main(int argc, char **argv) >

Re: [Mesa-dev] [PATCH shader-db] run: don't use alloca to avoid random crashes in the GLSL compiler

2016-12-08 Thread Nicolai Hähnle
On 07.12.2016 19:03, Ian Romanick wrote: On 12/07/2016 09:44 AM, Marek Olšák wrote: On Wed, Dec 7, 2016 at 6:42 PM, Ilia Mirkin wrote: What's wrong with feeding it stack memory? I don't really have an answer to that. Does valgrind provide any clues? The usual problems are running out of s

Re: [Mesa-dev] [PATCH shader-db] run: don't use alloca to avoid random crashes in the GLSL compiler

2016-12-07 Thread Jan Vesely
On Wed, 2016-12-07 at 18:44 +0100, Marek Olšák wrote: > On Wed, Dec 7, 2016 at 6:42 PM, Ilia Mirkin wrote: > > What's wrong with feeding it stack memory? > > I don't really have an answer to that. what happens when you malloc shader[i].length + 1 instead of +1000? looks like you're just hiding o

Re: [Mesa-dev] [PATCH shader-db] run: don't use alloca to avoid random crashes in the GLSL compiler

2016-12-07 Thread Ian Romanick
On 12/07/2016 09:44 AM, Marek Olšák wrote: > On Wed, Dec 7, 2016 at 6:42 PM, Ilia Mirkin wrote: >> What's wrong with feeding it stack memory? > > I don't really have an answer to that. Does valgrind provide any clues? The usual problems are running out of stack (is that still a thing?) or buffe

Re: [Mesa-dev] [PATCH shader-db] run: don't use alloca to avoid random crashes in the GLSL compiler

2016-12-07 Thread Marek Olšák
On Wed, Dec 7, 2016 at 6:42 PM, Ilia Mirkin wrote: > What's wrong with feeding it stack memory? I don't really have an answer to that. Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-de

Re: [Mesa-dev] [PATCH shader-db] run: don't use alloca to avoid random crashes in the GLSL compiler

2016-12-07 Thread Ilia Mirkin
What's wrong with feeding it stack memory? On Wed, Dec 7, 2016 at 12:33 PM, Marek Olšák wrote: > From: Marek Olšák > > --- > run.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/run.c b/run.c > index 08fd543..ded224a 100644 > --- a/run.c > +++ b/run.c > @@ -656,28

[Mesa-dev] [PATCH shader-db] run: don't use alloca to avoid random crashes in the GLSL compiler

2016-12-07 Thread Marek Olšák
From: Marek Olšák --- run.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/run.c b/run.c index 08fd543..ded224a 100644 --- a/run.c +++ b/run.c @@ -656,28 +656,32 @@ main(int argc, char **argv) /* If there's only one GLSL shader, mark it separable so