Re: [Mesa-dev] [PATCH v2] anv: fix bug when using component qualifier in FS outputs

2017-11-29 Thread Samuel Iglesias Gonsálvez
On Tue, 2017-11-28 at 12:59 -0800, Jason Ekstrand wrote: > On Tue, Nov 14, 2017 at 10:39 PM, Samuel Iglesias Gonsálvez < > sigles...@igalia.com> wrote: > > > We can write to the same output but in different components, like > > in this example: > > > > layout(location = 0, component = 0) out ivec

Re: [Mesa-dev] [PATCH v2] anv: fix bug when using component qualifier in FS outputs

2017-11-29 Thread Samuel Iglesias Gonsálvez
On Tue, 2017-11-28 at 12:49 -0800, Ian Romanick wrote: > Based on my (weak) understanding things in this part of the code, I > think this is ok. There are a couple minor nits below. With those > addressed and unless Jason has (time to give) some objections, this > patch is > > Reviewed-by: Ian R

Re: [Mesa-dev] [PATCH v2] anv: fix bug when using component qualifier in FS outputs

2017-11-28 Thread Jason Ekstrand
On Tue, Nov 14, 2017 at 10:39 PM, Samuel Iglesias Gonsálvez < sigles...@igalia.com> wrote: > We can write to the same output but in different components, like > in this example: > > layout(location = 0, component = 0) out ivec2 dEQP_FragColor_0; > layout(location = 0, component = 2) out ivec2 dEQP

Re: [Mesa-dev] [PATCH v2] anv: fix bug when using component qualifier in FS outputs

2017-11-28 Thread Ian Romanick
Based on my (weak) understanding things in this part of the code, I think this is ok. There are a couple minor nits below. With those addressed and unless Jason has (time to give) some objections, this patch is Reviewed-by: Ian Romanick On 11/28/2017 02:06 AM, Samuel Iglesias Gonsálvez wrote:

Re: [Mesa-dev] [PATCH v2] anv: fix bug when using component qualifier in FS outputs

2017-11-28 Thread Samuel Iglesias Gonsálvez
This patch is still unreviewed. Sam On Wed, 2017-11-15 at 07:39 +0100, Samuel Iglesias Gonsálvez wrote: > We can write to the same output but in different components, like > in this example: > > layout(location = 0, component = 0) out ivec2 dEQP_FragColor_0; > layout(location = 0, component = 2)

[Mesa-dev] [PATCH v2] anv: fix bug when using component qualifier in FS outputs

2017-11-14 Thread Samuel Iglesias Gonsálvez
We can write to the same output but in different components, like in this example: layout(location = 0, component = 0) out ivec2 dEQP_FragColor_0; layout(location = 0, component = 2) out ivec2 dEQP_FragColor_1; Therefore, they are not two different outputs but only one. Fixes: dEQP-VK.glsl.440.