Re: [Mesa-dev] [PATCH v2] etnaviv: Allow clearing constant buffer using buffer==NULL user_buffer==NULL

2017-11-01 Thread Wladimir J. van der Laan
On Wed, Nov 01, 2017 at 02:27:40PM +0100, Lucas Stach wrote: > Am Montag, den 30.10.2017, 17:14 +0100 schrieb Wladimir J. van der Laan: > > On Mon, Oct 30, 2017 at 02:21:07PM +0100, Lucas Stach wrote: > > > I would prefer the shorter expression (!cb->buffer && !cb->user_buffer)  > > > here, which

Re: [Mesa-dev] [PATCH v2] etnaviv: Allow clearing constant buffer using buffer==NULL user_buffer==NULL

2017-11-01 Thread Lucas Stach
Am Montag, den 30.10.2017, 17:14 +0100 schrieb Wladimir J. van der Laan: > On Mon, Oct 30, 2017 at 02:21:07PM +0100, Lucas Stach wrote: > > I would prefer the shorter expression (!cb->buffer && !cb->user_buffer)  > > here, which seems more consistent with the rest of the codebase. > > Well, I

Re: [Mesa-dev] [PATCH v2] etnaviv: Allow clearing constant buffer using buffer==NULL user_buffer==NULL

2017-10-30 Thread Wladimir J. van der Laan
On Mon, Oct 30, 2017 at 02:21:07PM +0100, Lucas Stach wrote: > I would prefer the shorter expression (!cb->buffer && !cb->user_buffer) > here, which seems more consistent with the rest of the codebase. Well, I mimiced the style from other assertion in the function which compares explicitly with

Re: [Mesa-dev] [PATCH v2] etnaviv: Allow clearing constant buffer using buffer==NULL user_buffer==NULL

2017-10-30 Thread Lucas Stach
Am Samstag, den 28.10.2017, 16:16 +0200 schrieb Wladimir J. van der Laan: > Prevents an assertion when using GALLIUM_HUD with ioquake3, > when cso_restore_constant_buffer_slot0 restores an empty > constant buffer in slot 0. > > > Signed-off-by: Wladimir J. van der Laan > --- >  

[Mesa-dev] [PATCH v2] etnaviv: Allow clearing constant buffer using buffer==NULL user_buffer==NULL

2017-10-28 Thread Wladimir J. van der Laan
Prevents an assertion when using GALLIUM_HUD with ioquake3, when cso_restore_constant_buffer_slot0 restores an empty constant buffer in slot 0. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/etnaviv_state.c | 2 +- 1 file changed, 1 insertion(+), 1