Re: [Mesa-dev] [PATCH v2] glcpp: Sync line number for macro

2018-08-10 Thread Zhaowei Yuan
Yuan; mesa-dev@lists.freedesktop.org > Cc: vlad.golovkin.m...@gmail.com; kenn...@whitecape.org; > ian.d.roman...@intel.com; tarc...@itsqueeze.com; > timothy.arc...@collabora.com > Subject: Re: [Mesa-dev] [PATCH v2] glcpp: Sync line number for macro > Importance: High > > Hi; > >

Re: [Mesa-dev] [PATCH v2] glcpp: Sync line number for macro

2018-08-10 Thread Tapani Pälli
Hi; On 08/10/2018 09:08 AM, Zhaowei Yuan wrote: Thank you for reminding me of the mistakes, I'll re-commit a PATCH v3, thanks However, I've re-tested those failed cases with latest code on master branch and got the same result. I don't why you didn't see anything wrong on your board, it

Re: [Mesa-dev] [PATCH v2] glcpp: Sync line number for macro

2018-08-10 Thread Zhaowei Yuan
Thank you for reminding me of the mistakes, I'll re-commit a PATCH v3, thanks However, I've re-tested those failed cases with latest code on master branch and got the same result. I don't why you didn't see anything wrong on your board, it doesn't make sense. On 08/07/2018 5:58 PM, Tapani Pälli

Re: [Mesa-dev] [PATCH v2] glcpp: Sync line number for macro

2018-08-07 Thread Tapani Pälli
On 07/22/2018 11:36 PM, zhaowei yuan wrote: Line number of a predefined macro should be set as where it is referenced rather than declared Patch v2 does nothing more except ccing more maintainers Signed-off-by: zhaowei yuan Bugzilla: https://patchwork.freedesktop.org/patch/225818/ Probably

[Mesa-dev] [PATCH v2] glcpp: Sync line number for macro

2018-07-23 Thread zhaowei yuan
Line number of a predefined macro should be set as where it is referenced rather than declared Patch v2 does nothing more except ccing more maintainers Signed-off-by: zhaowei yuan Bugzilla: https://patchwork.freedesktop.org/patch/225818/ --- src/compiler/glsl/glcpp/glcpp-lex.l | 1 +