Re: [Mesa-dev] [PATCH v2] glsl: Copy propagate in array index function parameters

2016-05-09 Thread Lars Hamre
Reviewed-by: Lars Hamre On Fri, May 6, 2016 at 11:54 AM, Juan A. Suarez Romero wrote: > Copy propagate is not applied in function parameters when they are out > or inout. > > But if the parameter is an array, we can copy propagate the index array. > >

Re: [Mesa-dev] [PATCH v2] glsl: Copy propagate in array index function parameters

2016-05-09 Thread Juan A. Suarez Romero
On Fri, 2016-05-06 at 12:23 -0400, Ilia Mirkin wrote: > Could you add something to piglit which tries this with AoA to make > sure that your logic is right? Sure. I've submitted a couple of tests that use another array for array indexing.

Re: [Mesa-dev] [PATCH v2] glsl: Copy propagate in array index function parameters

2016-05-06 Thread Ilia Mirkin
Could you add something to piglit which tries this with AoA to make sure that your logic is right? On Fri, May 6, 2016 at 11:54 AM, Juan A. Suarez Romero wrote: > Copy propagate is not applied in function parameters when they are out > or inout. > > But if the parameter is

[Mesa-dev] [PATCH v2] glsl: Copy propagate in array index function parameters

2016-05-06 Thread Juan A. Suarez Romero
Copy propagate is not applied in function parameters when they are out or inout. But if the parameter is an array, we can copy propagate the index array. This also fixes shaders@out-parameter-indexing piglit tests, that exposes a wrong handling of inout function parameters in Mesa. This commit