Re: [Mesa-dev] [PATCH v2] glsl: reuse main extension table to appropriate restrict extensions

2016-06-22 Thread Jakob Bornecrantz
So I have encountered bug that should be fixed by this. In my case its a happy little accident that I can use GL_ARB_gpu_shader5 in a compatibility context (since I want the textureGatherOffset functions). So while one part of me is happy that the bug exist. Cheers, Jakob.

Re: [Mesa-dev] [PATCH v2] glsl: reuse main extension table to appropriate restrict extensions

2016-06-22 Thread Ilia Mirkin
Urgh, just realized that I also need to teach glcpp about this stuff, otherwise we can end up with e.g. GL_ARB_gpu_shader5 defined but not enableable in a compat context. Also a discussion with Jakob on IRC pointed out that we currently allow GL_ARB_gpu_shader5 to be enabled in compat contexts, but

Re: [Mesa-dev] [PATCH v2] glsl: reuse main extension table to appropriate restrict extensions

2016-06-21 Thread Ilia Mirkin
Ping? I got a R-b from Eric Engestrom (thanks!) but I was hoping some more experienced Mesa contributors could give this a look and see if this makes sense or if I'm still missing some crucial bits. On Mon, Jun 13, 2016 at 11:43 PM, Ilia Mirkin wrote: > Previously we were only restricting based o

Re: [Mesa-dev] [PATCH v2] glsl: reuse main extension table to appropriate restrict extensions

2016-06-14 Thread Eric Engestrom
On Mon, Jun 13, 2016 at 11:43:57PM -0400, Ilia Mirkin wrote: > Previously we were only restricting based on ES/non-ES-ness and whether > the overall enable bit had been flipped on. However we have been adding > more fine-grained restrictions, such as based on compat profiles, as > well as specific

[Mesa-dev] [PATCH v2] glsl: reuse main extension table to appropriate restrict extensions

2016-06-13 Thread Ilia Mirkin
Previously we were only restricting based on ES/non-ES-ness and whether the overall enable bit had been flipped on. However we have been adding more fine-grained restrictions, such as based on compat profiles, as well as specific ES versions. Most of the time this doesn't matter, but it can create