Re: [Mesa-dev] [PATCH v2] i965: Fix calculation of layers array length for isl_view

2018-09-07 Thread Ilia Mirkin
FWIW, this looks right. Reviewed-by: Ilia Mirkin On Fri, Sep 7, 2018 at 11:39 AM, Danylo Piliaiev wrote: > Comment for array_len field states: > "Indicates the number of array elements starting at >Base Array Layer." > > And most usages of array_len expect it to be equal or less than > to

Re: [Mesa-dev] [PATCH v2] i965: Fix calculation of layers array length for isl_view

2018-09-07 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Fri, Sep 7, 2018 at 10:39 AM Danylo Piliaiev wrote: > Comment for array_len field states: > "Indicates the number of array elements starting at >Base Array Layer." > > And most usages of array_len expect it to be equal or less than > total layers - base laye

[Mesa-dev] [PATCH v2] i965: Fix calculation of layers array length for isl_view

2018-09-07 Thread Danylo Piliaiev
Comment for array_len field states: "Indicates the number of array elements starting at Base Array Layer." And most usages of array_len expect it to be equal or less than total layers - base layer v2: Do not subtract base layer if image unit is not layered (Ilia Mirkin) Fixes: 5a8c8903 Bugz