Re: [Mesa-dev] [PATCH v2] nv50/ir: improve maintainability of Target*::initOpInfo()

2018-06-29 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Fri, Jun 29, 2018 at 9:51 AM, Rhys Perry wrote: > This is mainly useful for when one needs to add new opcodes in a painless > and reliable way. > > Signed-off-by: Rhys Perry > --- > Changes in v2: > - use operation instead of uint32_t > - use ARRAY_SIZE() > - add

[Mesa-dev] [PATCH v2] nv50/ir: improve maintainability of Target*::initOpInfo()

2018-06-29 Thread Rhys Perry
This is mainly useful for when one needs to add new opcodes in a painless and reliable way. Signed-off-by: Rhys Perry --- Changes in v2: - use operation instead of uint32_t - use ARRAY_SIZE() - add "set below" comments I don't have push access. .../nouveau/codegen/nv50_ir_target_nv50.cpp