Re: [Mesa-dev] [PATCH v2] nv50/ir: rework the madsp subop handling

2017-12-02 Thread Tobias Klausmann
Hi, comments down below... Greetings, Tobias On 12/2/17 12:34 PM, Karol Herbst wrote: From: Karol Herbst Creating correct SubOps for OP_MADSP wasn't easy, because devs needed to know the proper values for each data type. Also the third source doesn't know any explicit

[Mesa-dev] [PATCH v2] nv50/ir: rework the madsp subop handling

2017-12-02 Thread Karol Herbst
From: Karol Herbst Creating correct SubOps for OP_MADSP wasn't easy, because devs needed to know the proper values for each data type. Also the third source doesn't know any explicit signess and the current code tried to work around this fact. To make the creating of the