Re: [Mesa-dev] [PATCH v2] radv: fix multisample image copies

2018-04-27 Thread Samuel Pitoiset
On 04/27/2018 02:30 PM, Matthew Nicholls wrote: I've verified the V2 of my patch does still fix the original issue I was seeing. You checked on Polaris, right? Vega still has an issue, working on it. Won't be ready for rc2. Thanks a bunch. Matthew. On 27/04/18 12:26, Samuel Pitoiset w

Re: [Mesa-dev] [PATCH v2] radv: fix multisample image copies

2018-04-27 Thread Samuel Pitoiset
On 04/27/2018 02:30 PM, Matthew Nicholls wrote: I've verified the V2 of my patch does still fix the original issue I was seeing. Thanks a bunch. Cool! Thanks for confirming, I will push the patch. Matthew. On 27/04/18 12:26, Samuel Pitoiset wrote: Matthew, can you double-check if v2 st

Re: [Mesa-dev] [PATCH v2] radv: fix multisample image copies

2018-04-27 Thread Matthew Nicholls
I've verified the V2 of my patch does still fix the original issue I was seeing. Thanks a bunch. Matthew. On 27/04/18 12:26, Samuel Pitoiset wrote: Matthew, can you double-check if v2 still fixes the issue for you? Thanks! On 04/27/2018 01:23 PM, Samuel Pitoiset wrote: From: Matthew Nicho

Re: [Mesa-dev] [PATCH v2] radv: fix multisample image copies

2018-04-27 Thread Samuel Pitoiset
Matthew, can you double-check if v2 still fixes the issue for you? Thanks! On 04/27/2018 01:23 PM, Samuel Pitoiset wrote: From: Matthew Nicholls Previously before fb077b0728, the LOD parameter was being used in place of the sample index, which would only copy the first sample to all samples in

[Mesa-dev] [PATCH v2] radv: fix multisample image copies

2018-04-27 Thread Samuel Pitoiset
From: Matthew Nicholls Previously before fb077b0728, the LOD parameter was being used in place of the sample index, which would only copy the first sample to all samples in the destination image. After that multisample image copies wouldn't copy anything from my observations. This fixes some cop