Re: [Mesa-dev] [PATCH v2] st: require compatible driver in autotools

2019-04-26 Thread Alyssa Ross
> if test -n "$with_gallium_drivers" -a "x$with_gallium_drivers" != xswrast; > then > if test "x$enable_xvmc" = xauto -a "x$have_xvmc_platform" = xyes; then > PKG_CHECK_EXISTS([xvmc >= $XVMC_REQUIRED], [enable_xvmc=yes], > [enable_xvmc=no]) > fi > ... > fi > > Thus auto-detection

Re: [Mesa-dev] [PATCH v2] st: require compatible driver in autotools

2019-04-24 Thread Emil Velikov
On Wed, 24 Apr 2019 at 13:09, Emil Velikov wrote: > > On Tue, 23 Apr 2019 at 23:10, Alyssa Ross wrote: > > > > > Off the top of my head - none of the VL code should be build when we > > > have only a swrast driver. > > > Can you try and kill that bug, or shall I? > > > > Isn't that what this

Re: [Mesa-dev] [PATCH v2] st: require compatible driver in autotools

2019-04-24 Thread Emil Velikov
On Tue, 23 Apr 2019 at 23:10, Alyssa Ross wrote: > > > Off the top of my head - none of the VL code should be build when we > > have only a swrast driver. > > Can you try and kill that bug, or shall I? > > Isn't that what this patch does? > > If there's only swrast, this patch prevents enabling

Re: [Mesa-dev] [PATCH v2] st: require compatible driver in autotools

2019-04-23 Thread Alyssa Ross
> Off the top of my head - none of the VL code should be build when we > have only a swrast driver. > Can you try and kill that bug, or shall I? Isn't that what this patch does? If there's only swrast, this patch prevents enabling any of the state trackers, so need_gallium_vl won't be set, and

Re: [Mesa-dev] [PATCH v2] st: require compatible driver in autotools

2019-04-23 Thread Emil Velikov
On Fri, 19 Apr 2019 at 19:53, Alyssa Ross wrote: > > The meson build system already has these checks. I've just copied them > to autotools. > > Without this, state trackers could be enabled when building with the > following set of options, which resulted in a compile error due to VL > being

[Mesa-dev] [PATCH v2] st: require compatible driver in autotools

2019-04-19 Thread Alyssa Ross
The meson build system already has these checks. I've just copied them to autotools. Without this, state trackers could be enabled when building with the following set of options, which resulted in a compile error due to VL being built without DRM. --enable-autotools