Great, thanks Chris.
Ilia, I'll push the patches today.
Iago
On Sat, 2014-06-28 at 08:46 +1200, Chris Forbes wrote:
Ilia,
That bikeshed is already done :)
I just send an r-b for v3 of patch 18, which is the last patch that lacked
one.
I think this is all good to land now.
--
Iago,
Not sure where you are with these patches... I guess some updates have
been requested to rename stream - index in some places? Anyways, once
the generic bits are all sorted out and reviewed, I'd appreciate it if
they could be pushed out, even if you're still working out hw-related
issues
Ilia,
That bikeshed is already done :)
I just send an r-b for v3 of patch 18, which is the last patch that lacked one.
I think this is all good to land now.
-- Chris
On Sat, Jun 28, 2014 at 5:11 AM, Ilia Mirkin imir...@alum.mit.edu wrote:
Iago,
Not sure where you are with these patches...
Hi,
this is a summary of the review process for the multi-stream support
series. Most of the patches got a reviewed-by by either Chris or Ian and
if I am not mistaken only 4 patches still need a reviewed-by so I
hopefully we get these 4 reviewed soon :). Here is the situation of each
of
I sent comments on patch 18 - I think it can be made to work correctly
when not doing real SO.
It seems everyone allows EmitStreamVertex(0), so I think you should
follow suit. It would be nice to get the spec clarified to explicitly
allow this.
Patches 11, 12 and 21 are:
Reviewed-by: Chris
This series addresses review comments of the previous version and adds a few
things. Summary of the changes in version 2:
Patch 1:
- Ian: multiple layout(location=) qualifiers
+ This was not a problem in the end.
- Chris: s/explicitely/explicitly/
- Chris: Remove 'Id' suffix in
