Re: [Mesa-dev] [PATCH v2 000/103] i965 Haswell ARB_gpu_shader_fp64 / OpenGL 4.0

Hello Matt, We have pushed all the patches except the last one... > * i965/gen7: expose OpenGL 4.0 on Haswell > >   We are currently discussing it with Curro :-) > We plan to send another patch series with the needed changes to enable OpenGL 4.0 on Haswell and all the suggestions we got from

Re: [Mesa-dev] [PATCH v2 000/103] i965 Haswell ARB_gpu_shader_fp64 / OpenGL 4.0

On Thu, 2016-12-22 at 12:13 -0600, Matt Turner wrote: > On Tue, Dec 13, 2016 at 2:01 AM, Samuel Iglesias Gonsálvez > wrote: > > On Mon, 2016-12-05 at 15:21 -0800, Matt Turner wrote: > > > i965/vec4: add a helper function to create double immediates > > > > > >   Can

Re: [Mesa-dev] [PATCH v2 000/103] i965 Haswell ARB_gpu_shader_fp64 / OpenGL 4.0

On Tue, Dec 13, 2016 at 2:01 AM, Samuel Iglesias Gonsálvez wrote: > On Mon, 2016-12-05 at 15:21 -0800, Matt Turner wrote: >> i965/vec4: add a helper function to create double immediates >> >> Can leave for later: Shouldn't we use the DIM instruction (on >> HSW)?

Re: [Mesa-dev] [PATCH v2 000/103] i965 Haswell ARB_gpu_shader_fp64 / OpenGL 4.0

On Wed, Dec 21, 2016 at 10:01 AM, Matt Turner wrote: > On Tue, Oct 11, 2016 at 4:01 AM, Iago Toral Quiroga wrote: >> i965/disasm: fix subreg for dst in Align16 mode > > I just noticed that this commit has a rebase mistake. Tim changed the > code in July

Re: [Mesa-dev] [PATCH v2 000/103] i965 Haswell ARB_gpu_shader_fp64 / OpenGL 4.0

On Tue, Oct 11, 2016 at 4:01 AM, Iago Toral Quiroga wrote: > i965/disasm: fix subreg for dst in Align16 mode I just noticed that this commit has a rebase mistake. Tim changed the code in July to use PRIu64, but this patch reverts back to %u.

Re: [Mesa-dev] [PATCH v2 000/103] i965 Haswell ARB_gpu_shader_fp64 / OpenGL 4.0

On Mon, 2016-12-19 at 11:31 -0600, Matt Turner wrote: > On Mon, Dec 19, 2016 at 2:00 AM, Samuel Iglesias Gonsálvez > wrote: > > Hello Matt, > > > > We have done most of the suggestions you made to our patches. > > However, > > we have replied to some of your

Re: [Mesa-dev] [PATCH v2 000/103] i965 Haswell ARB_gpu_shader_fp64 / OpenGL 4.0

On Mon, Dec 19, 2016 at 2:00 AM, Samuel Iglesias Gonsálvez wrote: > Hello Matt, > > We have done most of the suggestions you made to our patches. However, > we have replied to some of your questions/suggestions and we are > waiting for a reply before marking them as R-b or

Re: [Mesa-dev] [PATCH v2 000/103] i965 Haswell ARB_gpu_shader_fp64 / OpenGL 4.0

Hello Matt, We have done most of the suggestions you made to our patches. However, we have replied to some of your questions/suggestions and we are waiting for a reply before marking them as R-b or not. You can clone the new version of the patch series by running this command: $ git clone -b

Re: [Mesa-dev] [PATCH v2 000/103] i965 Haswell ARB_gpu_shader_fp64 / OpenGL 4.0

Samuel Iglesias Gonsálvez writes: > On Tue, 2016-12-13 at 09:01 +0100, Samuel Iglesias Gonsálvez wrote: >> > [...] >> > i965/vec4/nir: implement double comparisons >> > >> >Trivial: A newline before the if() would be nice. >> > >> >I have a memory of Curro

Re: [Mesa-dev] [PATCH v2 000/103] i965 Haswell ARB_gpu_shader_fp64 / OpenGL 4.0

On Tue, 2016-12-13 at 13:22 +0100, Samuel Iglesias Gonsálvez wrote: > On Sun, 2016-12-11 at 15:00 -0800, Matt Turner wrote: > > > > i965/vec4: handle 32 and 64 bit channels in liveness analysis > > > > Please indent the returned multiline expressions in > > var_from_reg() like we do

Re: [Mesa-dev] [PATCH v2 000/103] i965 Haswell ARB_gpu_shader_fp64 / OpenGL 4.0

On Sun, 2016-12-11 at 15:00 -0800, Matt Turner wrote: > i965/vec4: handle 32 and 64 bit channels in liveness analysis > > Please indent the returned multiline expressions in > var_from_reg() like we do elsewhere, so that the second line > begins on the same column as the first

Re: [Mesa-dev] [PATCH v2 000/103] i965 Haswell ARB_gpu_shader_fp64 / OpenGL 4.0

On Tue, 2016-12-13 at 09:01 +0100, Samuel Iglesias Gonsálvez wrote: > [...] > > i965/vec4/nir: implement double comparisons > > > > Trivial: A newline before the if() would be nice. > > > > I have a memory of Curro telling me that the hardware maps each > > 32-bit chunk in the dst

Re: [Mesa-dev] [PATCH v2 000/103] i965 Haswell ARB_gpu_shader_fp64 / OpenGL 4.0

Hello Matt! On Mon, 2016-12-05 at 15:21 -0800, Matt Turner wrote: > On 10/11, Iago Toral Quiroga wrote: > > It's been some time since > > ... anyone has reviewed your patches. Sorry. :( > > I'm going to review from your rebased i965-fp64-gen7-scalar-vec4-rc2 > branch. There have probably been

Re: [Mesa-dev] [PATCH v2 000/103] i965 Haswell ARB_gpu_shader_fp64 / OpenGL 4.0

i965/vec4: handle 32 and 64 bit channels in liveness analysis Please indent the returned multiline expressions in var_from_reg() like we do elsewhere, so that the second line begins on the same column as the first line. */ goes on its own line. I'm

Re: [Mesa-dev] [PATCH v2 000/103] i965 Haswell ARB_gpu_shader_fp64 / OpenGL 4.0

On Mon, 2016-12-05 at 15:21 -0800, Matt Turner wrote: > On 10/11, Iago Toral Quiroga wrote: > > > > It's been some time since > ... anyone has reviewed your patches. Sorry. :( > > I'm going to review from your rebased i965-fp64-gen7-scalar-vec4-rc2 > branch. There have probably been some

Re: [Mesa-dev] [PATCH v2 000/103] i965 Haswell ARB_gpu_shader_fp64 / OpenGL 4.0

On 10/11, Iago Toral Quiroga wrote: It's been some time since ... anyone has reviewed your patches. Sorry. :( I'm going to review from your rebased i965-fp64-gen7-scalar-vec4-rc2 branch. There have probably been some reorderings or other changes due to rebasing since the patches were sent, so

[Mesa-dev] [PATCH v2 000/103] i965 Haswell ARB_gpu_shader_fp64 / OpenGL 4.0

It's been some time since we sent the first version of the patches, so here is a v2, which adds: 1. Feedback from Curro to v1. I think the only thing missing is the suggestion to change the semantics of the offset() helper in vec4 to match those in the scalar backend. I sent this as a separate