Re: [Mesa-dev] [PATCH v2 03/10] radeonsi: restrict cube map derivative computations to the correct plane

2017-01-10 Thread Bas Nieuwenhuizen
Had some problems to figure out where the factor 2 came from, but in the end, this series is Reviewed-by: Bas Nieuwenhuizen On Tue, Jan 10, 2017 at 5:35 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > As remarked by

[Mesa-dev] [PATCH v2 03/10] radeonsi: restrict cube map derivative computations to the correct plane

2017-01-10 Thread Nicolai Hähnle
From: Nicolai Hähnle As remarked by the comment in the original code, the old algorithm fails when (tc + deriv) points at a different cube face. Instead, simply project the derivative directly to the plane of the selected cube face. The new code is based on exactly