Re: [Mesa-dev] [PATCH v2 03/29] mesa/main: clean up S3_s3tc check

2018-12-03 Thread Erik Faye-Lund
On Mon, 2018-12-03 at 12:15 -0500, Marek Olšák wrote: > Looks good. Feel free to push this. Thanks, pushed :) > > Marek > > On Mon, Dec 3, 2018 at 5:05 AM Erik Faye-Lund < > erik.faye-l...@collabora.com> wrote: > > On Fri, 2018-11-30 at 18:15 -0500, Marek Olšák wrote: > > > On Fri, Nov 30, 2018

Re: [Mesa-dev] [PATCH v2 03/29] mesa/main: clean up S3_s3tc check

2018-12-03 Thread Marek Olšák
Looks good. Feel free to push this. Marek On Mon, Dec 3, 2018 at 5:05 AM Erik Faye-Lund wrote: > On Fri, 2018-11-30 at 18:15 -0500, Marek Olšák wrote: > > On Fri, Nov 30, 2018 at 5:57 PM Ian Romanick > > wrote: > > > On 11/30/2018 02:17 PM, Marek Olšák wrote: > > > > > > > > > > > > On Fri, No

Re: [Mesa-dev] [PATCH v2 03/29] mesa/main: clean up S3_s3tc check

2018-12-03 Thread Erik Faye-Lund
On Fri, 2018-11-30 at 18:15 -0500, Marek Olšák wrote: > On Fri, Nov 30, 2018 at 5:57 PM Ian Romanick > wrote: > > On 11/30/2018 02:17 PM, Marek Olšák wrote: > > > > > > > > > On Fri, Nov 23, 2018 at 5:54 AM Erik Faye-Lund > > > > erik.faye-l...@collabora.com>> wrote: > > > > > > S3_s3tc is

Re: [Mesa-dev] [PATCH v2 03/29] mesa/main: clean up S3_s3tc check

2018-11-30 Thread Ian Romanick
On 11/30/2018 03:15 PM, Marek Olšák wrote: > On Fri, Nov 30, 2018 at 5:57 PM Ian Romanick > wrote: > > On 11/30/2018 02:17 PM, Marek Olšák wrote: > > > > > > On Fri, Nov 23, 2018 at 5:54 AM Erik Faye-Lund > >

Re: [Mesa-dev] [PATCH v2 03/29] mesa/main: clean up S3_s3tc check

2018-11-30 Thread Marek Olšák
On Fri, Nov 30, 2018 at 5:57 PM Ian Romanick wrote: > On 11/30/2018 02:17 PM, Marek Olšák wrote: > > > > > > On Fri, Nov 23, 2018 at 5:54 AM Erik Faye-Lund > > mailto:erik.faye-l...@collabora.com>> > wrote: > > > > S3_s3tc is the extension that enables this functionality on desktop, > so > >

Re: [Mesa-dev] [PATCH v2 03/29] mesa/main: clean up S3_s3tc check

2018-11-30 Thread Ian Romanick
On 11/30/2018 02:17 PM, Marek Olšák wrote: > > > On Fri, Nov 23, 2018 at 5:54 AM Erik Faye-Lund > mailto:erik.faye-l...@collabora.com>> wrote: > > S3_s3tc is the extension that enables this functionality on desktop, so > let's check for that one. The _mesa_has_S3_s3tc() helper already >

Re: [Mesa-dev] [PATCH v2 03/29] mesa/main: clean up S3_s3tc check

2018-11-30 Thread Marek Olšák
On Fri, Nov 23, 2018 at 5:54 AM Erik Faye-Lund wrote: > S3_s3tc is the extension that enables this functionality on desktop, so > let's check for that one. The _mesa_has_S3_s3tc() helper already > verifies the API according to the extension-table. > > Signed-off-by: Erik Faye-Lund > --- > src/m

[Mesa-dev] [PATCH v2 03/29] mesa/main: clean up S3_s3tc check

2018-11-23 Thread Erik Faye-Lund
S3_s3tc is the extension that enables this functionality on desktop, so let's check for that one. The _mesa_has_S3_s3tc() helper already verifies the API according to the extension-table. Signed-off-by: Erik Faye-Lund --- src/mesa/main/glformats.c | 8 +++- 1 file changed, 3 insertions(+), 5