Re: [Mesa-dev] [PATCH v2 1/3] i965: Sweep NIR after linking phase to free held memory

2018-07-24 Thread Mark Janes
This patch segfaults when both of the following environment variables are set: NIR_TEST_CLONE=true NIR_TEST_SERIALIZE=true Dylan -- please do not apply this to any stable branch until this bug has been resolved: https://bugs.freedesktop.org/show_bug.cgi?id=107366 -Mark Danylo Piliaiev writes:

Re: [Mesa-dev] [PATCH v2 1/3] i965: Sweep NIR after linking phase to free held memory

2018-07-17 Thread Danylo Piliaiev
Could it be pushed? The commit is independent from other in series. - Danil On 12.07.18 00:27, Jason Ekstrand wrote: Reviewed-by: Jason Ekstrand > On Wed, Jul 11, 2018 at 5:29 AM Danylo Piliaiev mailto:danylo.pilia...@gmail.com>> wrote: After optimization p

Re: [Mesa-dev] [PATCH v2 1/3] i965: Sweep NIR after linking phase to free held memory

2018-07-11 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Wed, Jul 11, 2018 at 5:29 AM Danylo Piliaiev wrote: > After optimization passes and many trasfromations most of memory > NIR holds is a garbage which was being freed only after shader deletion. > Freeing it at the end of linking will save memory which would be use

[Mesa-dev] [PATCH v2 1/3] i965: Sweep NIR after linking phase to free held memory

2018-07-11 Thread Danylo Piliaiev
After optimization passes and many trasfromations most of memory NIR holds is a garbage which was being freed only after shader deletion. Freeing it at the end of linking will save memory which would be useful in case there are a lot of complex shaders being compiled. The common case for this issue