Re: [Mesa-dev] [PATCH v2 1/4] softpipe: Add assert verifying successful pipe_transfer_map

2018-07-24 Thread Emil Velikov
On 17 July 2018 at 11:32, Robert Foss wrote: > This failure mode is a bit tricky to debug and manifests itself > later as a null pointer dereference, for which finding the origin > is needlessly tricky. > > Signed-off-by: Robert Foss Reviewed-by: Emil Velikov Ever so mildly related:

Re: [Mesa-dev] [PATCH v2 1/4] softpipe: Add assert verifying successful pipe_transfer_map

2018-07-18 Thread Robert Foss
Thanks Brian! On 2018-07-17 16:18, Brian Paul wrote: On 07/17/2018 04:32 AM, Robert Foss wrote: This failure mode is a bit tricky to debug and manifests itself later as a null pointer dereference, for which finding the origin is needlessly tricky. Signed-off-by: Robert Foss --- Changes

Re: [Mesa-dev] [PATCH v2 1/4] softpipe: Add assert verifying successful pipe_transfer_map

2018-07-17 Thread Brian Paul
On 07/17/2018 04:32 AM, Robert Foss wrote: This failure mode is a bit tricky to debug and manifests itself later as a null pointer dereference, for which finding the origin is needlessly tricky. Signed-off-by: Robert Foss --- Changes since v1: - Patch added

[Mesa-dev] [PATCH v2 1/4] softpipe: Add assert verifying successful pipe_transfer_map

2018-07-17 Thread Robert Foss
This failure mode is a bit tricky to debug and manifests itself later as a null pointer dereference, for which finding the origin is needlessly tricky. Signed-off-by: Robert Foss --- Changes since v1: - Patch added src/gallium/drivers/softpipe/sp_tile_cache.c | 1 + 1 file changed, 1