Re: [Mesa-dev] [PATCH v2 1/9] util: Add a virtual memory allocator

2018-05-23 Thread Jordan Justen
On 2018-05-23 01:47:05, Eric Engestrom wrote: > On Wednesday, 2018-05-23 00:25:11 -0700, Jordan Justen wrote: > > On 2018-05-22 14:52:28, Scott D Phillips wrote: > > > + > > > +#ifndef NDEBUG > > > +static void > > > +util_vma_heap_validate(struct util_vma_heap *heap) > > > +{ > > > > I'd rather

Re: [Mesa-dev] [PATCH v2 1/9] util: Add a virtual memory allocator

2018-05-23 Thread Eric Engestrom
On Wednesday, 2018-05-23 00:25:11 -0700, Jordan Justen wrote: > On 2018-05-22 14:52:28, Scott D Phillips wrote: > > From: Jason Ekstrand > > > > This is simple linear-walk first-fit allocator roughly based on the > > allocator in the radeon winsys code. This allocator

Re: [Mesa-dev] [PATCH v2 1/9] util: Add a virtual memory allocator

2018-05-23 Thread Jordan Justen
On 2018-05-22 14:52:28, Scott D Phillips wrote: > From: Jason Ekstrand > > This is simple linear-walk first-fit allocator roughly based on the > allocator in the radeon winsys code. This allocator has two primary > functional differences: > > 1) It cleanly returns 0