Re: [Mesa-dev] [PATCH v2 14/32] glsl/shader_cache: Save and restore serialized nir in gl_program

On 20/10/17 09:03, Timothy Arceri wrote: This and the previous patch feels wrong. The glsl shader cache shouldn't be handling writing nir to disk. IMO you should add this functionality to nir_serialize.c (maybe rename is nir_cache.c ??). That way we have continue with the nir is a toolkit

Re: [Mesa-dev] [PATCH v2 14/32] glsl/shader_cache: Save and restore serialized nir in gl_program

This and the previous patch feels wrong. The glsl shader cache shouldn't be handling writing nir to disk. IMO you should add this functionality to nir_serialize.c (maybe rename is nir_cache.c ??). That way we have continue with the nir is a toolkit theme and we can easily reused the util to

[Mesa-dev] [PATCH v2 14/32] glsl/shader_cache: Save and restore serialized nir in gl_program

Signed-off-by: Jordan Justen --- src/compiler/glsl/shader_cache.cpp | 16 1 file changed, 16 insertions(+) diff --git a/src/compiler/glsl/shader_cache.cpp b/src/compiler/glsl/shader_cache.cpp index ca90cfde35..f43bd6b17e 100644 ---