Re: [Mesa-dev] [PATCH v2 18/23] i965: Implement GL_PRIMITIVES_GENERATED with non-zero streams.

2014-06-25 Thread Iago Toral
Hi Chris, On Tue, 2014-06-24 at 22:12 +1200, Chris Forbes wrote: > Continuing from this, I think you need a test to ensure that the > points emitted in nonzero streams are not accidentally rendered when > SO isn't active. > > According to that same section of the Haswell PRM, if SO Function > Ena

Re: [Mesa-dev] [PATCH v2 18/23] i965: Implement GL_PRIMITIVES_GENERATED with non-zero streams.

2014-06-24 Thread Kenneth Graunke
On Tuesday, June 24, 2014 09:53:02 PM Chris Forbes wrote: > It looks like you can have the SOL stage increment that counter even > when not doing any actual streamout, which should give you the correct > semantics. > > See the definition of 3DSTATE_STREAMOUT in the Haswell PRM, Volume 2b. You wan

Re: [Mesa-dev] [PATCH v2 18/23] i965: Implement GL_PRIMITIVES_GENERATED with non-zero streams.

2014-06-24 Thread Chris Forbes
Continuing from this, I think you need a test to ensure that the points emitted in nonzero streams are not accidentally rendered when SO isn't active. According to that same section of the Haswell PRM, if SO Function Enable is 0, it appears the StreamID bits are ignored entirely, rather than filte

Re: [Mesa-dev] [PATCH v2 18/23] i965: Implement GL_PRIMITIVES_GENERATED with non-zero streams.

2014-06-24 Thread Chris Forbes
It looks like you can have the SOL stage increment that counter even when not doing any actual streamout, which should give you the correct semantics. See the definition of 3DSTATE_STREAMOUT in the Haswell PRM, Volume 2b. You want: - dw1.31 SO Function Enable = 1 - dw1.25 SO Statistics Enable = 1

[Mesa-dev] [PATCH v2 18/23] i965: Implement GL_PRIMITIVES_GENERATED with non-zero streams.

2014-06-18 Thread Iago Toral Quiroga
So far we have been using CL_INVOCATION_COUNT to resolve this query but this is no good with streams, as only stream 0 reaches the clipping stage. >From ARB_transform_feedback3: "When a generated primitive query for a vertex stream is active, the primitives-generated count is incremented every t