Re: [Mesa-dev] [PATCH v2 2/2] i915: remove unnecessary `if`

2016-08-24 Thread Emil Velikov
On 15 August 2016 at 16:48, Chris Wilson wrote: > On Mon, Aug 15, 2016 at 03:51:21PM +0100, Eric Engestrom wrote: >> if (x) return true; else return false; >> can be simplified as: >> return x; >> since `x` is already a boolean expression. >> >>

Re: [Mesa-dev] [PATCH v2 2/2] i915: remove unnecessary `if`

2016-08-15 Thread Chris Wilson
On Mon, Aug 15, 2016 at 03:51:21PM +0100, Eric Engestrom wrote: > if (x) return true; else return false; > can be simplified as: > return x; > since `x` is already a boolean expression. > > Signed-off-by: Eric Engestrom Both Reviewed-by: Chris Wilson

[Mesa-dev] [PATCH v2 2/2] i915: remove unnecessary `if`

2016-08-15 Thread Eric Engestrom
if (x) return true; else return false; can be simplified as: return x; since `x` is already a boolean expression. Signed-off-by: Eric Engestrom --- v2: replace `x == 0` with `!x` for consistency. src/mesa/drivers/dri/i915/intel_screen.c | 4 +--- 1