Re: [Mesa-dev] [PATCH v2 23/23] nir: verify destination bit size when checking algebraic optimizations

2016-04-04 Thread Samuel Iglesias Gonsálvez
On 01/04/16 21:35, Jason Ekstrand wrote: > Unless I'm missing something, this series doesn't contain anything that > uses this patch. Let's drop it for now and put it in with whatever adds > the actual nir_opt_algebraic changes. > Yeah, the user of this will be included in next patch series.

Re: [Mesa-dev] [PATCH v2 23/23] nir: verify destination bit size when checking algebraic optimizations

2016-04-01 Thread Jason Ekstrand
Unless I'm missing something, this series doesn't contain anything that uses this patch. Let's drop it for now and put it in with whatever adds the actual nir_opt_algebraic changes. Another option would be to silently bail if nir_search tries to create an expression where the opcode has an

[Mesa-dev] [PATCH v2 23/23] nir: verify destination bit size when checking algebraic optimizations

2016-03-31 Thread Samuel Iglesias Gonsálvez
Some instructions (like flrp in i965) cannot be lowered depending on the bit size because it doesn't support all bit sizes. If the bit size field is defined in nir_opt_algebraic.py, take it into account. Signed-off-by: Samuel Iglesias Gonsálvez ---