Re: [Mesa-dev] [PATCH v2 3/3] nir: simplify node matching code when lowering to SSA

2018-04-11 Thread Caio Marcelo de Oliveira Filho
On Wed, Apr 11, 2018 at 11:45:57AM -0700, Jason Ekstrand wrote: > I tweaked your commit messages a bit, added my R-B to this one, and pushed. Thanks. Your title reads better. Thanks, Caio ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH v2 3/3] nir: simplify node matching code when lowering to SSA

2018-04-11 Thread Jason Ekstrand
I tweaked your commit messages a bit, added my R-B to this one, and pushed. And... Now I get to rebase my deref patches again. :-P --Jason On Tue, Apr 10, 2018 at 11:13 PM, Caio Marcelo de Oliveira Filho < caio.olive...@intel.com> wrote: > The matching code doesn't make real use of the return

[Mesa-dev] [PATCH v2 3/3] nir: simplify node matching code when lowering to SSA

2018-04-11 Thread Caio Marcelo de Oliveira Filho
The matching code doesn't make real use of the return value. The main function return value is ignored, and while the worker function propagate its return value, the actual callback never returns false. v2: Style fixes. (Jason) --- src/compiler/nir/nir_lower_vars_to_ssa.c | 67