Re: [Mesa-dev] [PATCH v2 39/53] intel/compiler: add a helper to do conversions between integer and half-float

2019-01-04 Thread Iago Toral
On Fri, 2019-01-04 at 02:02 -0800, Francisco Jerez wrote: > Iago Toral writes: > > > On Wed, 2019-01-02 at 15:00 -0800, Francisco Jerez wrote: > > > Iago Toral Quiroga writes: > > > > > > > There are hardware restrictions to consider that seem to affect > > > > atom platforms > > > > only. > >

Re: [Mesa-dev] [PATCH v2 39/53] intel/compiler: add a helper to do conversions between integer and half-float

2019-01-04 Thread Francisco Jerez
Iago Toral writes: > On Wed, 2019-01-02 at 15:00 -0800, Francisco Jerez wrote: >> Iago Toral Quiroga writes: >> >> > There are hardware restrictions to consider that seem to affect >> > atom platforms >> > only. >> >> Same comment here as for PATCH 13 of this series. This and PATCH 40 >>

Re: [Mesa-dev] [PATCH v2 39/53] intel/compiler: add a helper to do conversions between integer and half-float

2019-01-04 Thread Iago Toral
On Wed, 2019-01-02 at 15:00 -0800, Francisco Jerez wrote: > Iago Toral Quiroga writes: > > > There are hardware restrictions to consider that seem to affect > > atom platforms > > only. > > Same comment here as for PATCH 13 of this series. This and PATCH 40 > shouldn't be necessary anymore

Re: [Mesa-dev] [PATCH v2 39/53] intel/compiler: add a helper to do conversions between integer and half-float

2019-01-02 Thread Francisco Jerez
Iago Toral Quiroga writes: > There are hardware restrictions to consider that seem to affect atom platforms > only. Same comment here as for PATCH 13 of this series. This and PATCH 40 shouldn't be necessary anymore with [1] in place. Please drop them. [1]

Re: [Mesa-dev] [PATCH v2 39/53] intel/compiler: add a helper to do conversions between integer and half-float

2019-01-02 Thread Pohjolainen, Topi
On Wed, Dec 19, 2018 at 12:51:07PM +0100, Iago Toral Quiroga wrote: > There are hardware restrictions to consider that seem to affect atom platforms > only. > --- > src/intel/compiler/brw_fs_nir.cpp | 32 +++ > 1 file changed, 32 insertions(+) Reviewed-by: Topi

[Mesa-dev] [PATCH v2 39/53] intel/compiler: add a helper to do conversions between integer and half-float

2018-12-19 Thread Iago Toral Quiroga
There are hardware restrictions to consider that seem to affect atom platforms only. --- src/intel/compiler/brw_fs_nir.cpp | 32 +++ 1 file changed, 32 insertions(+) diff --git a/src/intel/compiler/brw_fs_nir.cpp b/src/intel/compiler/brw_fs_nir.cpp index