Re: [Mesa-dev] [PATCH v3] freedreno/ir3: Make imageStore use num components from image format

2018-12-18 Thread Rob Clark
On Tue, Dec 18, 2018 at 9:46 AM Ilia Mirkin wrote: > > On Tue, Dec 18, 2018 at 9:42 AM Eduardo Lima Mitev wrote: > > > > emit_intrinsic_store_image() is always using 4 components when > > collecting registers for the value. When image has less than > > 4 components (e.g, r32f, r32i, r32ui) this

Re: [Mesa-dev] [PATCH v3] freedreno/ir3: Make imageStore use num components from image format

2018-12-18 Thread Ilia Mirkin
On Tue, Dec 18, 2018 at 9:42 AM Eduardo Lima Mitev wrote: > > emit_intrinsic_store_image() is always using 4 components when > collecting registers for the value. When image has less than > 4 components (e.g, r32f, r32i, r32ui) this results in extra mov > instructions. > > This patch uses the

[Mesa-dev] [PATCH v3] freedreno/ir3: Make imageStore use num components from image format

2018-12-18 Thread Eduardo Lima Mitev
emit_intrinsic_store_image() is always using 4 components when collecting registers for the value. When image has less than 4 components (e.g, r32f, r32i, r32ui) this results in extra mov instructions. This patch uses the actual number of components from the image format. For example, in a