Re: [Mesa-dev] [PATCH v3] i965/blorp: Fix hiz ops on MSAA surfaces

2016-02-10 Thread Alejandro Piñeiro
On 09/02/16 02:29, Jordan Justen wrote: > On 2016-02-06 10:25:59, Ben Widawsky wrote: >> On Sat, Feb 06, 2016 at 12:01:50PM +0100, Alejandro Piñeiro wrote: >>> From: Chris Forbes >>> >>> Two things were broken here: >>> - The depth/stencil surface dimensions were broken for

Re: [Mesa-dev] [PATCH v3] i965/blorp: Fix hiz ops on MSAA surfaces

2016-02-08 Thread Jordan Justen
On 2016-02-06 10:25:59, Ben Widawsky wrote: > On Sat, Feb 06, 2016 at 12:01:50PM +0100, Alejandro Piñeiro wrote: > > From: Chris Forbes > > > > Two things were broken here: > > - The depth/stencil surface dimensions were broken for MSAA. > > - Sample count was programmed

Re: [Mesa-dev] [PATCH v3] i965/blorp: Fix hiz ops on MSAA surfaces

2016-02-06 Thread Ben Widawsky
On Sat, Feb 06, 2016 at 12:01:50PM +0100, Alejandro Piñeiro wrote: > From: Chris Forbes > > Two things were broken here: > - The depth/stencil surface dimensions were broken for MSAA. > - Sample count was programmed incorrectly. > > Result was the depth resolve didn't work

Re: [Mesa-dev] [PATCH v3] i965/blorp: Fix hiz ops on MSAA surfaces

2016-02-06 Thread Alejandro Piñeiro
On 06/02/16 19:25, Ben Widawsky wrote: > On Sat, Feb 06, 2016 at 12:01:50PM +0100, Alejandro Piñeiro wrote: >> From: Chris Forbes >> >> Two things were broken here: >> - The depth/stencil surface dimensions were broken for MSAA. >> - Sample count was programmed incorrectly. >>

Re: [Mesa-dev] [PATCH v3] i965/blorp: Fix hiz ops on MSAA surfaces

2016-02-06 Thread Ilia Mirkin
On Sat, Feb 6, 2016 at 6:01 AM, Alejandro Piñeiro wrote: > I also slightly changed the commit message to reflect that this patch > fixes bug #76396. Also removed the "Signed-off-by: Chris Forbes > " because is not technically true anymore. Chris can >

[Mesa-dev] [PATCH v3] i965/blorp: Fix hiz ops on MSAA surfaces

2016-02-06 Thread Alejandro Piñeiro
From: Chris Forbes Two things were broken here: - The depth/stencil surface dimensions were broken for MSAA. - Sample count was programmed incorrectly. Result was the depth resolve didn't work correctly on MSAA surfaces, and so sampling the surface later produced garbage.