Re: [Mesa-dev] [PATCH v3] i965: Fix calculation of layers array length for isl_view

2018-11-14 Thread Jason Ekstrand
On Wed, Nov 14, 2018 at 6:02 AM Danylo Piliaiev wrote: > Hi Ilia, Jason, > > All these cases are indeed could induce confusion, > I'll try to explain all of them: > > Texture is not layered: > Layers: 1 > Base Layer: %layer of image unit% + %layer of texture view% > > Layered 3D

Re: [Mesa-dev] [PATCH v3] i965: Fix calculation of layers array length for isl_view

2018-11-14 Thread Danylo Piliaiev
Hi Ilia, Jason, All these cases are indeed could induce confusion, I'll try to explain all of them: Texture is not layered:     Layers: 1     Base Layer: %layer of image unit% + %layer of texture view% Layered 3D texture:     Layers: Entire level is bound, texture view does not affect layers

Re: [Mesa-dev] [PATCH v3] i965: Fix calculation of layers array length for isl_view

2018-11-13 Thread Ilia Mirkin
On Tue, Nov 13, 2018 at 4:53 PM Jason Ekstrand wrote: > > On Mon, Sep 10, 2018 at 10:21 AM Danylo Piliaiev > wrote: >> >> Handle all cases in calculation of layers count for isl_view >> taking into account texture view and image unit. >> st_convert_image was taken as a reference. >> >> When

Re: [Mesa-dev] [PATCH v3] i965: Fix calculation of layers array length for isl_view

2018-11-13 Thread Jason Ekstrand
On Mon, Sep 10, 2018 at 10:21 AM Danylo Piliaiev wrote: > Handle all cases in calculation of layers count for isl_view > taking into account texture view and image unit. > st_convert_image was taken as a reference. > > When u->Layered is true the whole level is taken with respect to > image

Re: [Mesa-dev] [PATCH v3] i965: Fix calculation of layers array length for isl_view

2018-11-13 Thread Danylo Piliaiev
Hello, Could anyone look at the patch? Thanks! On 10/24/18 2:22 PM, Danylo Piliaiev wrote: I have made a Piglit test that exercises the issue: https://patchwork.freedesktop.org/patch/258180/ - Danil On 9/10/18 6:21 PM, Danylo Piliaiev wrote: Handle all cases in calculation of layers count

Re: [Mesa-dev] [PATCH v3] i965: Fix calculation of layers array length for isl_view

2018-10-24 Thread Danylo Piliaiev
I have made a Piglit test that exercises the issue: https://patchwork.freedesktop.org/patch/258180/ - Danil On 9/10/18 6:21 PM, Danylo Piliaiev wrote: Handle all cases in calculation of layers count for isl_view taking into account texture view and image unit. st_convert_image was taken as a

[Mesa-dev] [PATCH v3] i965: Fix calculation of layers array length for isl_view

2018-09-10 Thread Danylo Piliaiev
Handle all cases in calculation of layers count for isl_view taking into account texture view and image unit. st_convert_image was taken as a reference. When u->Layered is true the whole level is taken with respect to image view. In other case only one layer is taken. v3: (Józef Kucia and Ilia