Re: [Mesa-dev] [PATCH v3 0/8] deal with multiple appearances of the same layout-qualifier-name in a single declaration

2016-11-10 Thread Andres Gomez
On Thu, 2016-11-10 at 19:21 +1100, Timothy Arceri wrote: > On Wed, 2016-11-09 at 23:09 -0800, Kenneth Graunke wrote: > > On Wednesday, October 26, 2016 6:30:43 PM PST Andres Gomez wrote: > > [snip] > > > > > > The main changes in this v3 series are: > > >   Patch 2/8 has been modified to use an ad

Re: [Mesa-dev] [PATCH v3 0/8] deal with multiple appearances of the same layout-qualifier-name in a single declaration

2016-11-10 Thread Timothy Arceri
On Wed, 2016-11-09 at 23:09 -0800, Kenneth Graunke wrote: > On Wednesday, October 26, 2016 6:30:43 PM PST Andres Gomez wrote: > [snip] > > > > The main changes in this v3 series are: > >   Patch 2/8 has been modified to use an additional default_layout > > variable instead of a layout_helper a

Re: [Mesa-dev] [PATCH v3 0/8] deal with multiple appearances of the same layout-qualifier-name in a single declaration

2016-11-09 Thread Kenneth Graunke
On Wednesday, October 26, 2016 6:30:43 PM PST Andres Gomez wrote: [snip] > The main changes in this v3 series are: > Patch 2/8 has been modified to use an additional default_layout > variable instead of a layout_helper and the merges are done > directly on the layout one. > Old patch v2

[Mesa-dev] [PATCH v3 0/8] deal with multiple appearances of the same layout-qualifier-name in a single declaration

2016-10-26 Thread Andres Gomez
In the case of layout-qualifier-names that can appear multiple times in different declarations of the same shader or, even, the same program, but that have to consistently hold the same value we are using the ast_layout_expression class which holds a list to store all the appearances to be able to