Re: [Mesa-dev] [PATCH v3 002/104] nir: Add a deref instruction type

On Mon, Apr 9, 2018 at 4:41 PM, Bas Nieuwenhuizen wrote: > On Tue, Apr 10, 2018 at 12:37 AM, Rob Clark wrote: > > On Mon, Apr 9, 2018 at 1:35 AM, Jason Ekstrand > wrote: > >> Rather lively discussion we've got going here... >

Re: [Mesa-dev] [PATCH v3 002/104] nir: Add a deref instruction type

On Tue, Apr 10, 2018 at 12:37 AM, Rob Clark wrote: > On Mon, Apr 9, 2018 at 1:35 AM, Jason Ekstrand wrote: >> Rather lively discussion we've got going here... >> >> On Sun, Apr 8, 2018 at 3:23 PM, Rob Clark wrote: >>> >>> On Sun,

Re: [Mesa-dev] [PATCH v3 002/104] nir: Add a deref instruction type

On Mon, Apr 9, 2018 at 1:35 AM, Jason Ekstrand wrote: > Rather lively discussion we've got going here... > > On Sun, Apr 8, 2018 at 3:23 PM, Rob Clark wrote: >> >> On Sun, Apr 8, 2018 at 5:54 PM, Bas Nieuwenhuizen >> wrote: >>

Re: [Mesa-dev] [PATCH v3 002/104] nir: Add a deref instruction type

On Mon, Apr 9, 2018 at 10:25 AM, Jason Ekstrand wrote: > On Mon, Apr 9, 2018 at 5:35 AM, Rob Clark wrote: >> >> On Mon, Apr 9, 2018 at 1:35 AM, Jason Ekstrand >> wrote: >> > Rather lively discussion we've got going here... >> > >>

Re: [Mesa-dev] [PATCH v3 002/104] nir: Add a deref instruction type

On Mon, Apr 9, 2018 at 5:35 AM, Rob Clark wrote: > On Mon, Apr 9, 2018 at 1:35 AM, Jason Ekstrand > wrote: > > Rather lively discussion we've got going here... > > > > On Sun, Apr 8, 2018 at 3:23 PM, Rob Clark wrote: > >> > >> On

Re: [Mesa-dev] [PATCH v3 002/104] nir: Add a deref instruction type

On Mon, Apr 9, 2018 at 1:35 AM, Jason Ekstrand wrote: > Rather lively discussion we've got going here... > > On Sun, Apr 8, 2018 at 3:23 PM, Rob Clark wrote: >> >> On Sun, Apr 8, 2018 at 5:54 PM, Bas Nieuwenhuizen >> wrote: >>

Re: [Mesa-dev] [PATCH v3 002/104] nir: Add a deref instruction type

On Mon, Apr 9, 2018 at 1:35 AM, Jason Ekstrand wrote: > Rather lively discussion we've got going here... > > On Sun, Apr 8, 2018 at 3:23 PM, Rob Clark wrote: >> >> On Sun, Apr 8, 2018 at 5:54 PM, Bas Nieuwenhuizen >> wrote: >>

Re: [Mesa-dev] [PATCH v3 002/104] nir: Add a deref instruction type

Rather lively discussion we've got going here... On Sun, Apr 8, 2018 at 3:23 PM, Rob Clark wrote: > On Sun, Apr 8, 2018 at 5:54 PM, Bas Nieuwenhuizen > wrote: > > On Sun, Apr 8, 2018 at 11:40 PM, Rob Clark wrote: > >> On Sun,

Re: [Mesa-dev] [PATCH v3 002/104] nir: Add a deref instruction type

On Sun, Apr 8, 2018 at 5:54 PM, Bas Nieuwenhuizen wrote: > On Sun, Apr 8, 2018 at 11:40 PM, Rob Clark wrote: >> On Sun, Apr 8, 2018 at 5:20 PM, Bas Nieuwenhuizen >> wrote: >>> + >>> + /** The mode of the

Re: [Mesa-dev] [PATCH v3 002/104] nir: Add a deref instruction type

On Sun, Apr 8, 2018 at 11:40 PM, Rob Clark wrote: > On Sun, Apr 8, 2018 at 5:20 PM, Bas Nieuwenhuizen > wrote: >> + >> + /** The mode of the underlying variable */ >> + nir_variable_mode mode; > > In fact,

Re: [Mesa-dev] [PATCH v3 002/104] nir: Add a deref instruction type

On Sun, Apr 8, 2018 at 5:20 PM, Bas Nieuwenhuizen wrote: > + > + /** The mode of the underlying variable */ > + nir_variable_mode mode; In fact, it seems like deref->mode is unused outside of nir_print and

Re: [Mesa-dev] [PATCH v3 002/104] nir: Add a deref instruction type

On Sun, Apr 8, 2018 at 10:43 PM, Bas Nieuwenhuizen wrote: > On Sun, Apr 8, 2018 at 10:23 PM, Bas Nieuwenhuizen > wrote: >> On Tue, Apr 3, 2018 at 8:32 PM, Jason Ekstrand wrote: >>> This commit adds a new instruction type

Re: [Mesa-dev] [PATCH v3 002/104] nir: Add a deref instruction type

+ + /** The mode of the underlying variable */ + nir_variable_mode mode; >>> >>> In fact, it seems like deref->mode is unused outside of nir_print and >>> nir_validate.. for logical addressing we can get the mode from the >>> deref_var->var at the

Re: [Mesa-dev] [PATCH v3 002/104] nir: Add a deref instruction type

On Sun, Apr 8, 2018 at 4:26 PM, Bas Nieuwenhuizen wrote: > On Sun, Apr 8, 2018 at 6:06 PM, Rob Clark wrote: >> On Sun, Apr 8, 2018 at 11:15 AM, Bas Nieuwenhuizen >> wrote: >>> On Sun, Apr 8, 2018 at 3:29 PM, Rob Clark

Re: [Mesa-dev] [PATCH v3 002/104] nir: Add a deref instruction type

On Sun, Apr 8, 2018 at 10:23 PM, Bas Nieuwenhuizen wrote: > On Tue, Apr 3, 2018 at 8:32 PM, Jason Ekstrand wrote: >> This commit adds a new instruction type to NIR for handling derefs. >> Nothing uses it yet but this adds the data structure as well

Re: [Mesa-dev] [PATCH v3 002/104] nir: Add a deref instruction type

On Sun, Apr 8, 2018 at 6:06 PM, Rob Clark wrote: > On Sun, Apr 8, 2018 at 11:15 AM, Bas Nieuwenhuizen > wrote: >> On Sun, Apr 8, 2018 at 3:29 PM, Rob Clark wrote: >>> On Sun, Apr 8, 2018 at 8:58 AM, Bas Nieuwenhuizen >>>

Re: [Mesa-dev] [PATCH v3 002/104] nir: Add a deref instruction type

On Tue, Apr 3, 2018 at 8:32 PM, Jason Ekstrand wrote: > This commit adds a new instruction type to NIR for handling derefs. > Nothing uses it yet but this adds the data structure as well as all of > the code to validate, print, clone, and [de]serialize them. > --- >

Re: [Mesa-dev] [PATCH v3 002/104] nir: Add a deref instruction type

On Sun, Apr 8, 2018 at 11:15 AM, Bas Nieuwenhuizen wrote: > On Sun, Apr 8, 2018 at 3:29 PM, Rob Clark wrote: >> On Sun, Apr 8, 2018 at 8:58 AM, Bas Nieuwenhuizen >> wrote: >>> On Sun, Apr 8, 2018 at 1:38 PM, Rob Clark

Re: [Mesa-dev] [PATCH v3 002/104] nir: Add a deref instruction type

On Sun, Apr 8, 2018 at 3:29 PM, Rob Clark wrote: > On Sun, Apr 8, 2018 at 8:58 AM, Bas Nieuwenhuizen > wrote: >> On Sun, Apr 8, 2018 at 1:38 PM, Rob Clark wrote: >>> On Tue, Apr 3, 2018 at 2:32 PM, Jason Ekstrand

Re: [Mesa-dev] [PATCH v3 002/104] nir: Add a deref instruction type

On Sun, Apr 8, 2018 at 8:58 AM, Bas Nieuwenhuizen wrote: > On Sun, Apr 8, 2018 at 1:38 PM, Rob Clark wrote: >> On Tue, Apr 3, 2018 at 2:32 PM, Jason Ekstrand wrote: >>> This commit adds a new instruction type to NIR for

Re: [Mesa-dev] [PATCH v3 002/104] nir: Add a deref instruction type

On Sun, Apr 8, 2018 at 1:38 PM, Rob Clark wrote: > On Tue, Apr 3, 2018 at 2:32 PM, Jason Ekstrand wrote: >> This commit adds a new instruction type to NIR for handling derefs. >> Nothing uses it yet but this adds the data structure as well as all of >>

Re: [Mesa-dev] [PATCH v3 002/104] nir: Add a deref instruction type

On Tue, Apr 3, 2018 at 2:32 PM, Jason Ekstrand wrote: > This commit adds a new instruction type to NIR for handling derefs. > Nothing uses it yet but this adds the data structure as well as all of > the code to validate, print, clone, and [de]serialize them. > --- >

[Mesa-dev] [PATCH v3 002/104] nir: Add a deref instruction type

This commit adds a new instruction type to NIR for handling derefs. Nothing uses it yet but this adds the data structure as well as all of the code to validate, print, clone, and [de]serialize them. --- src/compiler/nir/nir.c| 50 +++ src/compiler/nir/nir.h