Re: [Mesa-dev] [PATCH v3 13/14] glsl: add subroutine index qualifier support

2015-11-20 Thread Tapani Pälli
Reviewed-by: Tapani Pälli On 11/14/2015 03:42 PM, Timothy Arceri wrote: From: Timothy Arceri ARB_explicit_uniform_location allows the index for subroutine functions to be explicitly set in the shader. This patch reduces the restriction on the index qualifier in validate_layout_qualifiers() t

Re: [Mesa-dev] [PATCH v3 13/14] glsl: add subroutine index qualifier support

2015-11-19 Thread Timothy Arceri
On Fri, 2015-11-20 at 14:25 +1100, Timothy Arceri wrote: > Hi Dave/Tapani, > > This is the last patch in this series unreviewed is either of you able to > review is as you guys implemented the respective extensions. Forgot to say that there are piglit compile tests in master under ARB_explicit_u

Re: [Mesa-dev] [PATCH v3 13/14] glsl: add subroutine index qualifier support

2015-11-19 Thread Timothy Arceri
Hi Dave/Tapani, This is the last patch in this series unreviewed is either of you able to review is as you guys implemented the respective extensions. Thanks, Tim ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mail

[Mesa-dev] [PATCH v3 13/14] glsl: add subroutine index qualifier support

2015-11-14 Thread Timothy Arceri
From: Timothy Arceri ARB_explicit_uniform_location allows the index for subroutine functions to be explicitly set in the shader. This patch reduces the restriction on the index qualifier in validate_layout_qualifiers() to allow it to be applied to subroutines and adds the new subroutine qualifie