Re: [Mesa-dev] [PATCH v3 13/16] glsl: Add an option to clamp block indices when lowering UBO/SSBOs

2016-05-23 Thread Timothy Arceri
On Mon, 2016-05-23 at 16:07 -0700, Kenneth Graunke wrote: > On Friday, May 20, 2016 4:53:24 PM PDT Jason Ekstrand wrote: > > > > This prevents array overflow when the block is actually an array of > > UBOs or > > SSBOs.  On some hardware such as i965, such overflows can cause GPU > > hangs. > >

Re: [Mesa-dev] [PATCH v3 13/16] glsl: Add an option to clamp block indices when lowering UBO/SSBOs

2016-05-23 Thread Kenneth Graunke
On Friday, May 20, 2016 4:53:24 PM PDT Jason Ekstrand wrote: > This prevents array overflow when the block is actually an array of UBOs or > SSBOs. On some hardware such as i965, such overflows can cause GPU hangs. > > Reviewed-by: Ian Romanick > --- >

[Mesa-dev] [PATCH v3 13/16] glsl: Add an option to clamp block indices when lowering UBO/SSBOs

2016-05-20 Thread Jason Ekstrand
This prevents array overflow when the block is actually an array of UBOs or SSBOs. On some hardware such as i965, such overflows can cause GPU hangs. Reviewed-by: Ian Romanick --- src/compiler/glsl/ir_optimization.h | 2 +- src/compiler/glsl/linker.cpp