Re: [Mesa-dev] [PATCH v3 29/48] intel/cs: Rework the way thread local ID is handled

2017-10-31 Thread Iago Toral
On Mon, 2017-10-30 at 11:34 -0700, Jason Ekstrand wrote: > On Mon, Oct 30, 2017 at 12:33 AM, Iago Toral > wrote: > > On Fri, 2017-10-27 at 12:37 -0700, Jason Ekstrand wrote: > > > On Fri, Oct 27, 2017 at 2:11 AM, Iago Toral > > > wrote: > > > > On Wed,

Re: [Mesa-dev] [PATCH v3 29/48] intel/cs: Rework the way thread local ID is handled

2017-10-30 Thread Jason Ekstrand
On Mon, Oct 30, 2017 at 12:33 AM, Iago Toral wrote: > On Fri, 2017-10-27 at 12:37 -0700, Jason Ekstrand wrote: > > On Fri, Oct 27, 2017 at 2:11 AM, Iago Toral wrote: > > On Wed, 2017-10-25 at 16:26 -0700, Jason Ekstrand wrote: > > Previously,

Re: [Mesa-dev] [PATCH v3 29/48] intel/cs: Rework the way thread local ID is handled

2017-10-30 Thread Iago Toral
On Fri, 2017-10-27 at 12:37 -0700, Jason Ekstrand wrote: > On Fri, Oct 27, 2017 at 2:11 AM, Iago Toral > wrote: > > On Wed, 2017-10-25 at 16:26 -0700, Jason Ekstrand wrote: > > > > > Previously, brw_nir_lower_intrinsics added the param and then > > emitted > > > > > a > > >

Re: [Mesa-dev] [PATCH v3 29/48] intel/cs: Rework the way thread local ID is handled

2017-10-27 Thread Jason Ekstrand
On Fri, Oct 27, 2017 at 2:11 AM, Iago Toral wrote: > On Wed, 2017-10-25 at 16:26 -0700, Jason Ekstrand wrote: > > Previously, brw_nir_lower_intrinsics added the param and then emitted > > a > > load_uniform intrinsic to load it directly. This commit switches > > things > >

Re: [Mesa-dev] [PATCH v3 29/48] intel/cs: Rework the way thread local ID is handled

2017-10-27 Thread Iago Toral
On Wed, 2017-10-25 at 16:26 -0700, Jason Ekstrand wrote: > Previously, brw_nir_lower_intrinsics added the param and then emitted > a > load_uniform intrinsic to load it directly.  This commit switches > things > over to use a specific NIR intrinsic for the thread id.  The one > thing I > don't

[Mesa-dev] [PATCH v3 29/48] intel/cs: Rework the way thread local ID is handled

2017-10-25 Thread Jason Ekstrand
Previously, brw_nir_lower_intrinsics added the param and then emitted a load_uniform intrinsic to load it directly. This commit switches things over to use a specific NIR intrinsic for the thread id. The one thing I don't like about this approach is that we have to copy thread_local_id over to