Re: [Mesa-dev] [PATCH v3 4/6] nouveau: Add framebuffer modifier support

2018-03-02 Thread Thierry Reding
On Fri, Mar 02, 2018 at 12:28:02PM +, Daniel Stone wrote: > Hi, > > On 2 March 2018 at 12:06, Thierry Reding wrote: > > On Thu, Mar 01, 2018 at 09:37:28AM -0500, Ilia Mirkin wrote: > >> > +static void > >> > +nvc0_query_dmabuf_modifiers(struct pipe_screen *screen, > >> > +

Re: [Mesa-dev] [PATCH v3 4/6] nouveau: Add framebuffer modifier support

2018-03-02 Thread Daniel Stone
Hi, On 2 March 2018 at 12:06, Thierry Reding wrote: > On Thu, Mar 01, 2018 at 09:37:28AM -0500, Ilia Mirkin wrote: >> > +static void >> > +nvc0_query_dmabuf_modifiers(struct pipe_screen *screen, >> > +enum pipe_format format, int max, >> >> Maybe change this to "unsign

Re: [Mesa-dev] [PATCH v3 4/6] nouveau: Add framebuffer modifier support

2018-03-02 Thread Thierry Reding
On Thu, Mar 01, 2018 at 09:04:58AM -0800, Dylan Baker wrote: > Quoting Thierry Reding (2018-03-01 05:54:52) > > From: Thierry Reding > > > > This adds support for framebuffer modifiers to Nouveau. This will be > > used by the Tegra driver to share metadata about the format of buffers > > (such as

Re: [Mesa-dev] [PATCH v3 4/6] nouveau: Add framebuffer modifier support

2018-03-02 Thread Thierry Reding
On Thu, Mar 01, 2018 at 09:37:28AM -0500, Ilia Mirkin wrote: > On Thu, Mar 1, 2018 at 8:54 AM, Thierry Reding > wrote: > > From: Thierry Reding > > > > This adds support for framebuffer modifiers to Nouveau. This will be > > used by the Tegra driver to share metadata about the format of buffers

Re: [Mesa-dev] [PATCH v3 4/6] nouveau: Add framebuffer modifier support

2018-03-01 Thread Dylan Baker
Quoting Thierry Reding (2018-03-01 05:54:52) > From: Thierry Reding > > This adds support for framebuffer modifiers to Nouveau. This will be > used by the Tegra driver to share metadata about the format of buffers > (such as the tiling mode or compression). > > Changes in v2: > - remove unused p

Re: [Mesa-dev] [PATCH v3 4/6] nouveau: Add framebuffer modifier support

2018-03-01 Thread Ilia Mirkin
On Thu, Mar 1, 2018 at 8:54 AM, Thierry Reding wrote: > From: Thierry Reding > > This adds support for framebuffer modifiers to Nouveau. This will be > used by the Tegra driver to share metadata about the format of buffers > (such as the tiling mode or compression). > > Changes in v2: > - remove

[Mesa-dev] [PATCH v3 4/6] nouveau: Add framebuffer modifier support

2018-03-01 Thread Thierry Reding
From: Thierry Reding This adds support for framebuffer modifiers to Nouveau. This will be used by the Tegra driver to share metadata about the format of buffers (such as the tiling mode or compression). Changes in v2: - remove unused parameters to nouveau_buffer_create() - move format modifier q