Re: [Mesa-dev] [PATCH v3 5/9] i965/wm_surface_state: Use the clear address if it's non-zero

2018-04-23 Thread Jason Ekstrand
Sounds good On April 23, 2018 18:07:19 Nanley Chery wrote: On Mon, Apr 23, 2018 at 11:18:54AM -0700, Jason Ekstrand wrote: > I think you want to say "clear_color_bo is non-NULL" in the commit message > rather than talking about addresses. Otherwise, this looks like a

Re: [Mesa-dev] [PATCH v3 5/9] i965/wm_surface_state: Use the clear address if it's non-zero

2018-04-23 Thread Nanley Chery
On Mon, Apr 23, 2018 at 11:18:54AM -0700, Jason Ekstrand wrote: > I think you want to say "clear_color_bo is non-NULL" in the commit message > rather than talking about addresses. Otherwise, this looks like a very > nice clean-up. > To make sure we're on the same page, I made an error in using

Re: [Mesa-dev] [PATCH v3 5/9] i965/wm_surface_state: Use the clear address if it's non-zero

2018-04-23 Thread Jason Ekstrand
I think you want to say "clear_color_bo is non-NULL" in the commit message rather than talking about addresses. Otherwise, this looks like a very nice clean-up. Reviewed-by: Jason Ekstrand On Wed, Apr 11, 2018 at 1:42 PM, Nanley Chery wrote: > We

Re: [Mesa-dev] [PATCH v3 5/9] i965/wm_surface_state: Use the clear address if it's non-zero

2018-04-20 Thread Rafael Antognolli
Looks like this is the last patch in the series that is only cleaning up the mess I left behind by adding the clear color bo. Thanks for that. Reviewed-by: Rafael Antognolli On Wed, Apr 11, 2018 at 01:42:22PM -0700, Nanley Chery wrote: > We want to add and use a

[Mesa-dev] [PATCH v3 5/9] i965/wm_surface_state: Use the clear address if it's non-zero

2018-04-11 Thread Nanley Chery
We want to add and use a getter that turns off the indirect path by returning zero for the clear address. --- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c