Re: [Mesa-dev] [PATCH v4] mesa: improve ARB_copy_image internal format compat check

2015-03-12 Thread Jason Ekstrand
Sean, I got ready to push this and ran it against piglit and one of the tests errored out. Looking into it further, it was a bug in the test. I've sent a patch: http://lists.freedesktop.org/archives/piglit/2015-March/015156.html I'll merge the mesa commit once we get piglit fixed. --Jason On

Re: [Mesa-dev] [PATCH v4] mesa: improve ARB_copy_image internal format compat check

2015-03-12 Thread Jason Ekstrand
On Thu, Mar 12, 2015 at 9:24 PM, Jason Ekstrand ja...@jlekstrand.net wrote: Sean, I got ready to push this and ran it against piglit and one of the tests errored out. Looking into it further, it was a bug in the test. I've sent a patch:

Re: [Mesa-dev] [PATCH v4] mesa: improve ARB_copy_image internal format compat check

2015-03-12 Thread Sean Burke
Jason, No worries. It looks like my mail client munged the patch in some way. I'm sending it as an attachment in the hopes that it will remain untouched. Sean Burke On Wed, Mar 11, 2015 at 2:53 PM, Jason Ekstrand ja...@jlekstrand.net wrote: Sean, Sorry it's taken so long for me to get to

Re: [Mesa-dev] [PATCH v4] mesa: improve ARB_copy_image internal format compat check

2015-03-11 Thread Jason Ekstrand
Sean, Sorry it's taken so long for me to get to this, but I went to test/push this today and it doesn't apply against current mesa master. Can you please either rebase on master and re-send or give me the SHA1 hash of the commit this one is based on. (Not the SHA1 of this commit but the previous

Re: [Mesa-dev] [PATCH v4] mesa: improve ARB_copy_image internal format compat check

2015-03-08 Thread Jason Ekstrand
On Mar 7, 2015 10:33 PM, Kenneth Graunke kenn...@whitecape.org wrote: On Saturday, March 07, 2015 10:09:15 PM Jason Ekstrand wrote: LGTM. Jason, Sean doesn't have commit access (it's actually his first patch) - if this is good to go, would you mind pushing it for him? I thought as much.

[Mesa-dev] [PATCH v4] mesa: improve ARB_copy_image internal format compat check

2015-03-07 Thread Sean Burke
The memory layout of compatible internal formats may differ in bytes per block, so TexFormat is not a reliable measure of compatibility. For example, GL_RGB8 and GL_RGB8UI are compatible formats, but GL_RGB8 may be laid out in memory as B8G8R8X8. If GL_RGB8UI has a 3 byte-per-block memory layout,

Re: [Mesa-dev] [PATCH v4] mesa: improve ARB_copy_image internal format compat check

2015-03-07 Thread Kenneth Graunke
On Saturday, March 07, 2015 10:09:15 PM Jason Ekstrand wrote: LGTM. Jason, Sean doesn't have commit access (it's actually his first patch) - if this is good to go, would you mind pushing it for him? Nice work, Sean! --Ken signature.asc Description: This is a digitally signed message part.

Re: [Mesa-dev] [PATCH v4] mesa: improve ARB_copy_image internal format compat check

2015-03-07 Thread Jason Ekstrand
LGTM. On Mar 7, 2015 8:34 PM, Sean Burke leftmost...@gmail.com wrote: The memory layout of compatible internal formats may differ in bytes per block, so TexFormat is not a reliable measure of compatibility. For example, GL_RGB8 and GL_RGB8UI are compatible formats, but GL_RGB8 may be laid out