Re: [Mesa-dev] [PATCH v4 00/44] anv: SPV_KHR_16bit_storage/VK_KHR_16bit_storage for gen8+

2017-12-11 Thread Chema Casanova
El 09/12/17 a las 00:52, Jason Ekstrand escribió: > While reviewing some of the UBO pushing comments from Topi, I > discovered a fairly disturbing assert in brw_fs_nir.cpp in our > implementation of nir_intrinsic_load_uniform: > > /* Offsets are in bytes but they should always be

Re: [Mesa-dev] [PATCH v4 00/44] anv: SPV_KHR_16bit_storage/VK_KHR_16bit_storage for gen8+

2017-12-08 Thread Jason Ekstrand
While reviewing some of the UBO pushing comments from Topi, I discovered a fairly disturbing assert in brw_fs_nir.cpp in our implementation of nir_intrinsic_load_uniform: /* Offsets are in bytes but they should always be multiples of 4 */ assert(const_offset->u32[0] % 4 == 0);

Re: [Mesa-dev] [PATCH v4 00/44] anv: SPV_KHR_16bit_storage/VK_KHR_16bit_storage for gen8+

2017-12-06 Thread Alejandro Piñeiro
On 06/12/17 01:19, Chema Casanova wrote: > On 05/12/17 18:31, Chema Casanova wrote: >> El 05/12/17 a las 06:16, Jason Ekstrand escribió: >>> A couple of notes: >>> >>>  1) I *think* I gave you enough reviews to land the UBO/SSBO part and >>> the optimizations in 26-28.  If reviews are still

Re: [Mesa-dev] [PATCH v4 00/44] anv: SPV_KHR_16bit_storage/VK_KHR_16bit_storage for gen8+

2017-12-05 Thread Chema Casanova
On 05/12/17 18:31, Chema Casanova wrote: > El 05/12/17 a las 06:16, Jason Ekstrand escribió: >> A couple of notes: >> >>  1) I *think* I gave you enough reviews to land the UBO/SSBO part and >> the optimizations in 26-28.  If reviews are still missing anywhere, >> please let me know.  If not,

Re: [Mesa-dev] [PATCH v4 00/44] anv: SPV_KHR_16bit_storage/VK_KHR_16bit_storage for gen8+

2017-12-05 Thread Chema Casanova
El 05/12/17 a las 06:16, Jason Ekstrand escribió: > A couple of notes: > >  1) I *think* I gave you enough reviews to land the UBO/SSBO part and > the optimizations in 26-28.  If reviews are still missing anywhere, > please let me know.  If not, let's try and get that part landed. The series is

Re: [Mesa-dev] [PATCH v4 00/44] anv: SPV_KHR_16bit_storage/VK_KHR_16bit_storage for gen8+

2017-12-04 Thread Jason Ekstrand
A couple of notes: 1) I *think* I gave you enough reviews to land the UBO/SSBO part and the optimizations in 26-28. If reviews are still missing anywhere, please let me know. If not, let's try and get that part landed. 2) I send out a patch to rewrite assign_constant_locations which I think

[Mesa-dev] [PATCH v4 00/44] anv: SPV_KHR_16bit_storage/VK_KHR_16bit_storage for gen8+

2017-11-29 Thread Jose Maria Casanova Crespo
Hello, this is the V4 series for the implementation of the SPV_KHR_16bit_storage and VK_KHR_16bit_storage extensions on the anv vulkan driver, in addition to the GLSL and NIR support needed. The original series can be found here [1], the following v2 [2] and v3 [3]. In short V4 includes the