Re: [Mesa-dev] [PATCH v4 19/44] i965/fs: Use byte_scattered_write on 16-bit store_ssbo

2017-12-01 Thread Jason Ekstrand
On Fri, Dec 1, 2017 at 2:46 AM, Chema Casanova wrote: > On 01/12/17 11:12, Jason Ekstrand wrote: > > I've left some comments below that I think clean things up and make this > > better, but I believe it is correct as-is. > > > > Reviewed-by: Jason Ekstrand

Re: [Mesa-dev] [PATCH v4 19/44] i965/fs: Use byte_scattered_write on 16-bit store_ssbo

2017-12-01 Thread Chema Casanova
On 01/12/17 11:12, Jason Ekstrand wrote: > I've left some comments below that I think clean things up and make this > better, but I believe it is correct as-is. > > Reviewed-by: Jason Ekstrand > > > On Wed, Nov 29, 2017 at 6:42 PM, Jose Maria

Re: [Mesa-dev] [PATCH v4 19/44] i965/fs: Use byte_scattered_write on 16-bit store_ssbo

2017-12-01 Thread Jason Ekstrand
I've left some comments below that I think clean things up and make this better, but I believe it is correct as-is. Reviewed-by: Jason Ekstrand On Wed, Nov 29, 2017 at 6:42 PM, Jose Maria Casanova Crespo < jmcasan...@igalia.com> wrote: > From: Alejandro Piñeiro

[Mesa-dev] [PATCH v4 19/44] i965/fs: Use byte_scattered_write on 16-bit store_ssbo

2017-11-29 Thread Jose Maria Casanova Crespo
From: Alejandro Piñeiro We need to rely on byte scattered writes as untyped writes are 32-bit size. We could try to keep using 32-bit messages when we have two or four 16-bit elements, but for simplicity sake, we use the same message for any component number. We revisit