Re: [Mesa-dev] [PATCH v4 5/6] nir: Offset vertex_id by first_vertex instead of base_vertex

2018-04-06 Thread Jason Ekstrand
The first 5 are Reviewed-by: Jason Ekstrand I meant to just skim and ACK the Vulkan bits but then I did a full review. Oh, well. :-) On Fri, Apr 6, 2018 at 2:53 PM, Ian Romanick wrote: > From: Neil Roberts > > base_vertex will be zero for non-indexed calls and in that case we > need vertex_i

[Mesa-dev] [PATCH v4 5/6] nir: Offset vertex_id by first_vertex instead of base_vertex

2018-04-06 Thread Ian Romanick
From: Neil Roberts base_vertex will be zero for non-indexed calls and in that case we need vertex_id to be offset by the ‘first’ parameter instead. That is what we get with first_vertex. This is true for both GL and Vulkan. The freedreno driver is also setting vertex_id_zero_based on nir_options